chore(nginx): updated nodejs.org configuration #3139

ovflowd · 2022-12-31T02:18:29Z

This PR introduces several Nginx changes that simplify the current configuration and fix current bugs.

Configuration changes

Merge HTTP and HTTPS server blocks for redirects
Removes non-needed configuration from the default nodejs.org:80 server block
Removes the nodejs.org:80 redirect to nodejs.org:443 server block in favor of a return 301 rule
Removes legacy rules such as (/blog redirecting to blog.nodejs.org), which could cause a "too many redirects" error
Fixes the blog.nodejs.org:80 configuration which caused "too many redirects" and was broken
Removed broken server rules such as the newsletter.nodejs.org
Fixed broken foundation.nodejs.org location rules to the respective links of openjsf.org:443
Reorganised the file (first both 80/443 ports for nodejs.org then all the extras)
Added @todo's for the upcoming Next.js rewrite of nodejs.org

ovflowd · 2022-12-31T02:18:47Z

cc @nodejs/build @Trott @bnb @joesepi

ovflowd · 2023-01-03T21:52:47Z

cc @richardlau

ovflowd · 2023-01-04T14:56:38Z

@UlisesGascon could you also give an eye here 👀

richardlau · 2023-03-15T11:09:25Z

I've deployed this onto the server. I'm not feeling too well this week, so if anything looks wrong with these changes I'm likely to just back them out rather than try to troubleshoot.

nschonni · 2023-03-15T22:38:59Z

This appears to now redirecting http://unencrypted.nodejs.org/ traffic to HTTPS, where it's supposed to be a breakout for that traffic

nschonni · 2023-03-15T22:42:36Z

ansible/www-standalone/resources/config/nodejs.org

-        default_type text/plain;
-    }
-
-    location /.well-known/security.txt {


This no longer works/is being served

This file doesn't really exist. This rewrite can probably be deleted as this file is not being served anymore.

It did in that location before, and is now located https://github.com/nodejs/nodejs.org/blob/main/public/security.txt

No, I think you're confusing things. There was never a well-known/security.txt (https://github.com/nodejs/nodejs.org/tree/fb666ed663e4d0511beced38cf9505a688bde898/static) (ref before next migration).

Or are you trying to say that /.well-known/security.txt should redirect to /security.txt?

Oh, I see what you're talking about. Let me make a PR.

This redirect was serving the file in static/security.txt through the .well-known address, which is per it's spec https://securitytxt.org/

This redirect was serving the file in static/security.txt through the .well-known address, which is per it's spec securitytxt.org

Aware of that spec, my bad, I just switched these two 👀

ovflowd · 2023-03-15T22:42:56Z

I don't see any configuration for unecrypted.nodejs.org. (Whatever that was, it was not changed)

nschonni · 2023-03-15T22:46:26Z

There wasn't a specific config, but there wasn't a global HTTP to HTTPS rewrite rule before, which supported that old endpoint

ovflowd · 2023-03-15T22:48:07Z

Is there any reason we should support unencrypted.nodejs.org?

There wasn't a global rewrite, yes, but pretty much all the "meaningful" routes were being redirected to https. Which made sense to do a global redirect.

nschonni · 2023-03-15T22:53:21Z

It is there to support clients like NVM that need it for old platforms I believe, but maybe @ljharb can confirm.
It shouldn't be broken/dropped without a discussion with the TSC though

ovflowd · 2023-03-15T22:56:54Z

It is there to support clients like NVM that need it for old platforms I believe, but maybe @ljharb can confirm.
It shouldn't be broken/dropped without a discussion with the TSC though

Then it is working fine. Because it will not redirect for the /dist stuff :)

nschonni · 2023-03-15T23:00:38Z

No, it is breaking the dist

C:\Users\nick_>curl http://unencrypted.nodejs.org/dist/v0.1.27/SHASUMS256.txt
<html>
<head><title>404 Not Found</title></head>
<body bgcolor="white">
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.10.3 (Ubuntu)</center>
</body>
</html>

C:\Users\nick_>curl https://unencrypted.nodejs.org/dist/v0.1.27/SHASUMS256.txt
1f83401b9ede7558350e183fc4386234a803d1253e7fe99bce0aba7138270806  node-v0.1.27.tar.gz

ovflowd · 2023-03-15T23:01:07Z

@nschonni that's not how the unencrypted.nodejs.org apparentlya works. This is a valid URL curl -v http://unencrypted.nodejs.org/download/release/node-v0.6.5.tar.gz

If you curl -v http://unencrypted.nodejs.org, it gives you an HTML welcome page, and then I navigated over it. This URL seems to be served somewhere else, as the IP address is neither CloudFlare nor the server where nodejs.org is residing 🤔

ovflowd · 2023-03-15T23:03:25Z

Also curl -v http://unencrypted.nodejs.org/download/release/v19.8.1/ seems to be what would be curl -v https://nodejs.org/dist/v19.8.1/. Does this answer your questions?

BethGriggs · 2023-03-15T23:04:00Z

It shouldn't be broken/dropped without a discussion with the TSC though

There was some discussion in #2857 about unencrypted.nodejs.org, where we enabled HSTS.

ljharb · 2023-03-16T02:07:27Z

unless http traffic redirects to unencrypted, nvm doesn’t use it.

That said, it still seems important to preserve an http escape hatch.

richardlau · 2023-03-16T12:17:01Z

For a long time http://unencrypted.nodejs.org's landing page had a warning that it was to be sunset on 1 January 2022 (last year). #2857 (comment). My opinion is that it's not worth spending time resurrecting it.

ovflowd · 2023-03-16T12:18:01Z

If it was supposed to be sunset them we should sunset it 🤔

chore(nginx): updated nodejs.org configuration

2320feb

ovflowd added 2 commits December 31, 2022 03:24

chore(nginx): simplified redirect

9c7be51

chore(nginx): removed unused joyent log format

e037107

ovflowd mentioned this pull request Dec 31, 2022

chore(content): removed legacy and old unused content nodejs/nodejs.org#4987

Closed

chore(alias): remove robots.txt/security.txt alias

7ffa11c

ovflowd mentioned this pull request Mar 13, 2023

robots.txt doesn't behave as expected nodejs/nodejs.org#1948

Closed

richardlau approved these changes Mar 15, 2023

View reviewed changes

richardlau merged commit 92c5c08 into nodejs:main Mar 15, 2023

nschonni reviewed Mar 15, 2023

View reviewed changes

ovflowd deleted the patch-1 branch March 15, 2023 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(nginx): updated nodejs.org configuration #3139

chore(nginx): updated nodejs.org configuration #3139

ovflowd commented Dec 31, 2022

ovflowd commented Dec 31, 2022

ovflowd commented Jan 3, 2023

ovflowd commented Jan 4, 2023

richardlau commented Mar 15, 2023

nschonni commented Mar 15, 2023

nschonni Mar 15, 2023

ovflowd Mar 15, 2023 •

edited

nschonni Mar 15, 2023

ovflowd Mar 15, 2023

ovflowd Mar 15, 2023 •

edited

nschonni Mar 15, 2023

ovflowd Mar 15, 2023

ovflowd Mar 15, 2023

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023 •

edited

ovflowd commented Mar 15, 2023

BethGriggs commented Mar 15, 2023

ljharb commented Mar 16, 2023

richardlau commented Mar 16, 2023

ovflowd commented Mar 16, 2023

chore(nginx): updated nodejs.org configuration #3139

chore(nginx): updated nodejs.org configuration #3139

Conversation

ovflowd commented Dec 31, 2022

Configuration changes

ovflowd commented Dec 31, 2022

ovflowd commented Jan 3, 2023

ovflowd commented Jan 4, 2023

richardlau commented Mar 15, 2023

nschonni commented Mar 15, 2023

nschonni Mar 15, 2023

Choose a reason for hiding this comment

ovflowd Mar 15, 2023 • edited

Choose a reason for hiding this comment

nschonni Mar 15, 2023

Choose a reason for hiding this comment

ovflowd Mar 15, 2023

Choose a reason for hiding this comment

ovflowd Mar 15, 2023 • edited

Choose a reason for hiding this comment

nschonni Mar 15, 2023

Choose a reason for hiding this comment

ovflowd Mar 15, 2023

Choose a reason for hiding this comment

ovflowd Mar 15, 2023

Choose a reason for hiding this comment

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023

nschonni commented Mar 15, 2023

ovflowd commented Mar 15, 2023 • edited

ovflowd commented Mar 15, 2023

BethGriggs commented Mar 15, 2023

ljharb commented Mar 16, 2023

richardlau commented Mar 16, 2023

ovflowd commented Mar 16, 2023

ovflowd Mar 15, 2023 •

edited

ovflowd Mar 15, 2023 •

edited

ovflowd commented Mar 15, 2023 •

edited