Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(well-known): fixed inversed security.txt #3225

Merged
merged 1 commit into from Mar 16, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 15, 2023

This PR fixes the rewrite rule being reversed

@ovflowd
Copy link
Member Author

ovflowd commented Mar 16, 2023

cc @nodejs/build @targos

@targos targos merged commit f16ef55 into nodejs:main Mar 16, 2023
@ovflowd ovflowd deleted the patch-1 branch March 16, 2023 11:40
@nschonni
Copy link
Member

I'm not sure this was the right fix. The spec says that the /.well-known/security.txt is the preferred endpoint https://securitytxt.org/, but the root version is an acceptable fallback. Alternately both locations could be used to serve the file.

@ovflowd
Copy link
Member Author

ovflowd commented Mar 17, 2023

Well, this was the previous behaviour, pretty much I'd say.

Regardless, it is a redirect, so it is valid 🤷

@nschonni
Copy link
Member

No, the previous behaviour was to serve it from .well-known https://github.com/nodejs/build/pull/3139/files#r1137845438

@ovflowd
Copy link
Member Author

ovflowd commented Mar 17, 2023

Should be fixed by #3233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants