chore(nginx): improve try_files, fix rewrites, increase file cache #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Mar 17, 2023
|
a9aaa5e is currently deployed |
|
deployed e4cf44f |
|
deployed f479bfd |
MattIPv4
reviewed
Mar 17, 2023
| open_file_cache_valid 120s; | ||
| open_file_cache_min_uses 2; | ||
| open_file_cache_errors off; | ||
|
|
||
| error_page 404 @localized_404; | ||
| set $lang en; |
There was a problem hiding this comment.
Very minor nitpick, can this be moved down to be directly above the error_page directive, as they're related?
There was a problem hiding this comment.
I feel like I rather keeping this at the top, as it could be used in other places, and I'm afraid if it's right after there it will override the one from @english_fallback
MattIPv4
reviewed
Mar 17, 2023
| location @english_fallback { | ||
| # Store the original language of the request | ||
| # We'll use this for the 404 in the try_files in @localized_404 | ||
| if ($uri ~* ^/(ar|be|ca|de|es|fa|fr|gl|id|it|ja|ka|ko|nl|pt-br|ro|ru|tr|uk|zh-cn|zh-tw)/) { | ||
| set $lang $1; | ||
| } | ||
|
|
||
| rewrite ^/(ar|be|ca|de|es|fa|fr|gl|id|it|ja|ka|ko|nl|pt-br|ro|ru|tr|uk|zh-cn|zh-tw)/(.*)$ /en/$2; | ||
| rewrite ^/(ar|be|ca|de|es|fa|fr|gl|id|it|ja|ka|ko|nl|pt-br|ro|ru|tr|uk|zh-cn|zh-tw)/(.*)$ /en/$2 last; |
There was a problem hiding this comment.
Is this change actually needed now?
There was a problem hiding this comment.
It is verbose, but kinda goes with the behaviour we want to follow. Not really needed, but I feel like it's better to be explicit.
|
2513fe6 is deployed on both servers (live and fallback). |
richardlau
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cache_file cache to
100000, fixes rewrites by removing their/trailing slash, and remove unnecessarytry_filesfrom known failing conditions.