Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: replace old ubuntu1404 DO host with fedora38 #3352

Merged
merged 1 commit into from
May 17, 2023

Conversation

targos
Copy link
Member

@targos targos commented May 10, 2023

Refs: #3350

@targos

This comment was marked as resolved.

@targos targos mentioned this pull request May 10, 2023
2 tasks
@richardlau
Copy link
Member

Draft because the Jenkins service doesn't work:

May 10 09:46:56 test-digitalocean-fedora38-x64-1 java[931]: SEVERE: https://ci.nodejs.org/ provided port:41913 is not reachable on host ci.nodejs.org
May 10 09:46:56 test-digitalocean-fedora38-x64-1 java[931]: java.io.IOException: https://ci.nodejs.org/ provided port:41913 is not reachable on host ci.nodejs.org

@targos Since this is a new IP address you'll need to add it to the firewall for ci.nodejs.org (and possibly remove the old IP address if it's not being reused by us). FWIW instead of saving the current rules as foo before editing in practice we've been using filenames based on date/person doing the editing and haven't been removing them. I don't think there's a real reason/need for doing that (although I guess it does mean we could roll back to earlier iptables configs).

There is also a jenkins/host/iptables.yml playbook which in theory will configure iptables for ci.nodejs.org or ci-release.nodejs.org -- I'm not sure if it currently works for ci.nodejs.org (at one point I did fix it to work on ci-release.nodejs.org).

@targos
Copy link
Member Author

targos commented May 14, 2023

Thanks, I updated the firewall rules and Jenkins is now connected.
Test run: https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-latest-x64/52059/

@targos
Copy link
Member Author

targos commented May 14, 2023

Build went fine, but there's a failing test. I tried to run it 10 times and it always fails:

=== release test-net-bytes-per-incoming-chunk-overhead ===
Path: pummel/test-net-bytes-per-incoming-chunk-overhead
node:assert:399
    throw err;
    ^

AssertionError [ERR_ASSERTION]: measured 4549.4272 bytes per chunk
    at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js:49:3)
    at process.emit (node:events:523:35) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Node.js v21.0.0-pre
Command: out/Release/node --expose-gc /home/iojs/build/workspace/node-test-commit-linux/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js


[00:54|% 100|+   0|-  10]: Done

Failed tests:
out/Release/node --expose-gc /home/iojs/build/workspace/node-test-commit-linux/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js

@targos
Copy link
Member Author

targos commented May 14, 2023

I don't really know what to do about it...

@targos targos marked this pull request as ready for review May 17, 2023 14:30
@targos
Copy link
Member Author

targos commented May 17, 2023

I suggest we merge this, because the machine replacement happened, and track the test failure in #3350

@targos targos merged commit 1ba2d52 into nodejs:main May 17, 2023
@targos targos deleted the fedora38-do branch May 17, 2023 15:28
targos added a commit to targos/nodejs-build that referenced this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants