Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CITGM seems to be broken on master #536

Closed
joyeecheung opened this issue Jan 17, 2018 · 4 comments
Closed

CITGM seems to be broken on master #536

joyeecheung opened this issue Jan 17, 2018 · 4 comments

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jan 17, 2018 •
edited
Loading

  • Node Version: master
  • CitGM Version:3.1.2
  • Platform: all

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1205/

Refs: nodejs/node#18207
@joyeecheung
Copy link
Member Author

Trace:

error: failure             | spawn npm ENOENT    
error: failure             | spawn npm ENOENT    
/Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/node_modules/async/dist/async.js:955
        if (fn === null) throw new Error("Callback was already called.");
                         ^

Error: Callback was already called.
    at /Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/node_modules/async/dist/async.js:955:32
    at ChildProcess.<anonymous> (/Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/lib/grab-module-data.js:43:7)
    at ChildProcess.emit (events.js:131:13)
    at maybeClose (internal/child_process.js:943:16)
    at Socket.stream.socket.on (internal/child_process.js:363:11)
    at Socket.emit (events.js:131:13)
    at Pipe._handle.close [as _onclose] (net.js:592:12)
Build step 'Conditional steps (multiple)' marked build as failure

@addaleax
Copy link
Member

error: failure | spawn npm ENOENT

Sounds like something for @nodejs/build too?

@joyeecheung
Copy link
Member Author

@addaleax No, looks like something is broken on master. I am currently bisecting between 1385e1bc63(good) 85739b6c5b(bad)

@apapirovski
Copy link
Member

I've got the fix: nodejs/node#18210

@apapirovski apapirovski mentioned this issue Jan 17, 2018
Closed
3 tasks
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@apapirovski @MayaLekova
child_process: do not ignore proto values of env
53ea1a0 
This reverts this behaviour introduced in a recent PR, and updates
the test. Without this change, CitGM and other packages are broken.

PR-URL: nodejs#18210
Fixes: nodejs/citgm#536
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

child_process: do not ignore proto values of env apapirovski/node
3 participants
@apapirovski @addaleax @joyeecheung