Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable leveldown and level #694

Closed
targos opened this issue Mar 29, 2019 · 6 comments
Closed

Enable leveldown and level #694

targos opened this issue Mar 29, 2019 · 6 comments

Comments

@targos
Copy link
Member

targos commented Mar 29, 2019

Refs: nodejs/node#25060 (comment)

I tried to run citgm on them and found two problems related to the way CITGM works: it doesn't clone the repos. It downloads the tarballs from GitHub so there is no .git and submodules aren't pulled.

leveldown@5

../deps/leveldb/leveldb-1.20/port/port_posix.h:43:10: fatal error: snappy.h: No such file or directory

level@5

Error: Could not find .git repository at "/tmp/36f6ed9f-b0a7-4813-9794-1bee404b9b01/level

/cc @vweevers

@vweevers
Copy link
Contributor

The first error makes sense - but I'm not sure what we (Level) can do apart from reverting the use of submodules - the second error does not. Can you share/link to the complete log?

@targos
Copy link
Member Author

targos commented Mar 29, 2019

@vweevers
Copy link
Contributor

@targos I just released level@5.0.1 which should fix level.

@targos
Copy link
Member Author

targos commented Mar 29, 2019

@vweevers thanks a lot!

@targos
Copy link
Member Author

targos commented Mar 29, 2019

I have an idea for the submodule issue, hold on...

@targos
Copy link
Member Author

targos commented Mar 29, 2019

Fix proposed here: #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants