Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest CITGM results #997

Closed
RafaelGSS opened this issue Oct 2, 2023 · 25 comments
Closed

Latest CITGM results #997

RafaelGSS opened this issue Oct 2, 2023 · 25 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Oct 2, 2023 •
edited

Let's use this issue to list failing modules and take action such as removing offending modules, skip specific arches and so on

@nodejs/citgm
@ljharb
Copy link
Member

ljharb commented Oct 2, 2023

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

@alfonsograziano
Copy link
Contributor

I just had a nice chat with @RafaelGSS. Will look into it :)

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 2, 2023 •
edited

Regarding this test fail.
On my machine works fine with these specifications:

  • Node v20.8 (as in the CI run)
  • underscore-v1.13.6 (as in the CI run)
  • macOs version 13.6

Command run: citgm underscore@1.13.6
The tests are not flacky on this package.

@alfonsograziano
Copy link
Contributor

All the issues regarding macOS are not reproducible for me locally. I'm using the correct Node version and the correct package version, the tests are not failing on my machine. @nodejs/build

@RafaelGSS
Copy link
Member Author

Let's wait v18.x and main to see if the same happens for these versions. But, I guess that's something related to our machines.

@Trott
Copy link
Member

Trott commented Oct 2, 2023 •
edited

The failures on three platforms for nan already has an issue (#996). It would be great if someone could figure that one out. (I haven't looked and don't have the right expertise probably anyway.)

EDIT: Oh, I see @RafaelGSS already linked to it in the description. I'd love to see someone get to the bottom of that one.

@Trott
Copy link
Member

Trott commented Oct 2, 2023

The macOS failures have a PR that might be worth landing just to bypass things for straightforward JavaScript modules.

#971

@Trott
Copy link
Member

Trott commented Oct 2, 2023

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

@ljharb Is it possible to pass a longer timeout value via the command line? Something along the lines of npm run tests-only -- --timeout=99999? If so, it would just be a matter of updating line 483 of lookup.json.

citgm/lib/lookup.json

Line 483 in cd1b288

"scripts": ["tests-only"],

@Trott Trott mentioned this issue Oct 2, 2023
Open
4 tasks
@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 3, 2023 •
edited

Is really interesting to notice that in the last run on main there are no issues over macOS even without the skip applied, but on v18.18 there are 6 errors.

I managed to reproduce the issue over pino@8.15.3 and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

@alfonsograziano
Copy link
Contributor

@ljharb probably also semver failed due to a timeout. Shall we try to increase it or set it as flaky due to tests timeout?

@ruyadorno
Copy link
Member

ruyadorno commented Oct 3, 2023 •
edited

Please keep the max timeout to a reasonable amount. We don't want to end up with a citgm run that takes forever to timeout when something got stuck in the test.

@ruyadorno
Copy link
Member

I managed to reproduce the issue over pino@8.15.3 and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

While that's a good short-term solution to the problem, an actual fix should hopefully land in either multer or node so that it stop failing on macos. In these cases please open an issue pinging the maintainer - you can find it by browsing lookup.json e.g:

citgm/lib/lookup.json

Lines 337 to 341 in cd1b288

"multer": {
"prefix": "v",
"skip": "win32",
"maintainers": "linusu"
},

Here's an example of an issue pinging the maintainer of a package for help: #988. Keep in mind you might be able to post more info, since you're able to reproduce in your machine you might be able to add some helpful logs or maybe test which combinations of package version + node version it fails vs succeeds, etc.

Thanks for the help @alfonsograziano it's really appreciated! 🙏

@alfonsograziano
Copy link
Contributor

Here are a few issues/PRs open now to fix these issues:

@RafaelGSS
Copy link
Member Author

After merging both PRs:

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 8, 2023 •
edited

After the latest run on v18.18, we have 14 issues.

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 8, 2023 •
edited

After the latest run on v21.0.0, we have 14 issues.

@RafaelGSS
Copy link
Member Author

For the install failing, I think we should just drop these packages if we confirm these failures aren't machine-related.

jest: ENOSPC: no space left on device. Do we know how to fix it? @RafaelGSS

Usually, we open an issue on nodejs/build.

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 9, 2023 •
edited

For the install failing:

They are always failing on v18.18 but I cannot reproduce the failure on my local machine.
#1006 will skip them for now on OSX and at the same time will create an issue to find a proper solution :)

Usually, we open an issue on nodejs/build.

Done here:
nodejs/build#3512
Outcome: The space has been increased by deleting some files, we now have more than 5gb free. Hopefully shouldn't happen in the next run

@RafaelGSS
Copy link
Member Author

Next run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3316/ - long queue - we should wait a bit

@alfonsograziano
Copy link
Contributor

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

@richardlau
Copy link
Member

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

The CI job runs by default on published versions of CITGM -- there hasn't been a release with the changes to the lookup.

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Oct 10, 2023 •
edited

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

The CI job runs by default on published versions of CITGM -- there hasn't been a release with the changes to the lookup.

Should I use nodejs/citgm#main on
image
?

UPDATE: Running https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3318

@alfonsograziano
Copy link
Contributor

alfonsograziano commented Oct 11, 2023 •
edited

The current status after this run is: 15 failures on these packages:

@panva

This comment was marked as resolved.

Sign in to view
@BethGriggs BethGriggs mentioned this issue Nov 22, 2023
Closed
@RafaelGSS
Copy link
Member Author

It seems we got a green CI for LTS release lines. I'm opening #1033 for v21 failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ljharb @ruyadorno @panva @Trott @richardlau @alfonsograziano @RafaelGSS