Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable underscore on macOS #1008

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

alfonsograziano
Copy link
Contributor

Checklist
  • npm test passes
  • contribution guidelines followed
    here

Underscore is constantly failing on Node.js v18.x:

This PR will disable underscore for now.

@jashkenas you are listed as the maintainer of this package, can you please take a look at the issue and evaluate if is a legitimate issue or a false positive from citgm that we can fix? :)
By running citgm underscore I'm currently not able to reproduce the issue on my (macOS) machine.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c47ab10) 96.44% compared to head (6f34176) 95.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   96.44%   95.32%   -1.13%     
==========================================
  Files          28       28              
  Lines        2139     2139              
==========================================
- Hits         2063     2039      -24     
- Misses         76      100      +24     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BethGriggs BethGriggs merged commit 4e69eb4 into nodejs:main Nov 23, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants