chore: increasing timeout for ava #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 5, 2023
RafaelGSS
reviewed
Oct 6, 2023
the test fails after 4 minutes and 30 mins and there are still some tests that are missing. I'm not sure if 5 mins is enough. Maybe we can monitor the next runs and evaluate how much time it requires on average to finish |
RafaelGSS
approved these changes
Oct 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasseshere
In 2 cases in the recent builds ava failed due to timeouts. This PR increase the ava timeout to 10 minutes.
This is the issue reported:
Reference to the issues:
I'm not sure if this is a proper solution. As an alternative, we can set the module as flaky.
@sindresorhus @novemberborn I'm tagging you since you are listed as the package maintainers, maybe you have more info about how we can solve the issue :)