lib: allow modules without a script called test
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules do not call their test script `test`. For example, a module using Yarn workspaces may define `workspace:test` as their testing script. We can specify the script to run in our `lookup.json` but there was a place in our code that was specifically looking for a script called `test`.
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 30 30
Lines 889 889
=======================================
Hits 855 855
Misses 34 34
Continue to review full report at Codecov.
|
targos
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules do not call their test script
test. For example, amodule using Yarn workspaces may define
workspace:testas theirtesting script. We can specify the script to run in our
lookup.jsonbut there was a place in our code that was specifically looking for
a script called
test.Checklist
npm testpasseshere