fix: don't ignore engines with yarn v2+ #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
==========================================
+ Coverage 96.05% 96.12% +0.06%
==========================================
Files 31 31
Lines 913 929 +16
==========================================
+ Hits 877 893 +16
Misses 36 36
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
CI (using nodejs/node#35332 to avoid the umask deprecation noise): https://ci.nodejs.org/job/citgm-smoker/2483/ |
richardlau
force-pushed
the
yarn
branch
2 times, most recently
from
133de60
to
e7e5f21
Compare
richardlau
changed the title
richardlau
changed the title
richardlau
changed the title
richardlau
force-pushed
the
yarn
branch
2 times, most recently
from
40b52e0
to
a166fd4
Compare
yarn v2 doesn't support the `YARN_IGNORE_ENGINES` environment variable. We still need to set `YARN_IGNORE_ENGINES` for older versions of yarn to allow installation with unreleased versions of Node.js. Projects are able to use yarn policies to set the version of yarn they are using, so we need to version sniff to determine whether or not to set the environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn v2 doesn't support the
YARN_IGNORE_ENGINESenvironment variable.We still need to set
YARN_IGNORE_ENGINESfor older versions of yarnto allow installation with unreleased versions of Node.js. Projects are
able to use yarn policies to set the version of yarn they are using,
so we need to version sniff to determine whether or not to set the
environment variable.
Fixes: #824
Checklist
npm testpasseshere