lookup: deprecate and rename "master" field to "head" #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch the lookup object in memory for backwards-compatibility.
|
/cc @nodejs/citgm Deprecation message looks like this (The relative path is only for our internal lookup table. Otherwise it would be absolute): |
targos
changed the title
|
Ping @nodejs/citgm |
|
@targos should we mark this as Semver-Major just to be safe? Numbers are cheap :P |
|
I guess it doesn't matter much because we are probably the only users, but this should be backwards-compatible and actually fixes CITGM for some of the modules in our lookup that have |
|
@targos OK then let's mark Semver-Minor 👍 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 18, 2021
Patch the lookup object in memory for backwards-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch the lookup object in memory for backwards-compatibility.