Add test for other babel reexport checks #42
Conversation
|
Oh it looks like this isn't from an old version, it's the current (7.13.10) output when using (I wanted to see if this tests currently fails, but it looks like CI is disabled in PRs 🤔) |
guybedford
force-pushed
the
babel-reexport-checks
branch
from
40ddcb9
to
5a8aced
Compare
You can now see the failure explicitly :) |
|
Do you need help implementing support for this? I have some free time today/tomorrow. |
|
@nicolo-ribaudo if you can that would be a great help. |
|
@nicolo-ribaudo I've ended up just finding some time to look at this now, so if you haven't started yet I'll see what I can do, or if you have let me know how far you are. |
|
I haven't started yet, feel free to go ahead 👍 |
|
The problem here turned out to be the nested blocks! We only run this detection at the top-level. |
I was just testing out star exports on the Babel repl, and noticed these two cases likely also aren't yet supported.
I wonder how many other variations we're missing from past versions!
// cc @nicolo-ribaudo