Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules: accept "deps: V8" as the subsystem for revert commits #102

Merged
merged 1 commit into from
Oct 25, 2022
Merged

rules: accept "deps: V8" as the subsystem for revert commits #102

merged 1 commit into from
Oct 25, 2022

Commits on Oct 22, 2022

  1. rules: accept "deps: V8" as the subsystem for revert commits 

    The commit, nodejs/node@cbb4045,
was being flagged as invalid by core-validate-commit because of this
error:
```txt
Error: not ok 6 title-format: First word after subsystem(s) in title should be lowercase. (Revert "deps: V8: forward declaration of `Rtl*FunctionTable`")
```
This is incorrect because "deps: V8" is a valid subsystem. This change
makes sure that revert commits with such a subsystem is accepted.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    59b503a View commit details
    Browse the repository at this point in the history