rules: allow dashes in 'Fixes:' URL check #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, links to https://github.com/nodejs/node-gyp/issues were rejected because of the dash in 'node-gyp'. Notably, this fix means this commit log now passes validation. :-) Bug introduced in commit 2523fb9 ("rules: stricter `Fixes:` URL check") from March 30. Fixes: #60
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 13 13
Lines 206 206
=======================================
Hits 202 202
Misses 4 4
Continue to review full report at Codecov.
|
|
My apologies, I hadn't seen #55 yet. It would be good to have that (or this) merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, links to https://github.com/nodejs/node-gyp/issues
were rejected because of the dash in 'node-gyp'.
Notably, this fix means this commit log now passes validation. :-)
Bug introduced in commit 2523fb9 ("rules: stricter
Fixes:URL check")from March 30.
Fixes: #60