Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not hard fail if Corepack home folder cannot be created #382

Merged
merged 3 commits into from Feb 21, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 20, 2024

Fixes: #379

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test, one that runs HOME="/tmp/some/folder/here" yarn -v should be enough to reproduce the issue.

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 20, 2024

The reason the tests didn't catch it is because we specifically disable it:

process.env.COREPACK_DEFAULT_TO_LATEST = `0`;

If we re-enable it, it will cause the nock to be outdated as soon as Yarn publish a new version (if we use yarn -v) which is not ideal.

@aduh95 aduh95 requested a review from merceyz February 20, 2024 15:11
@aduh95 aduh95 merged commit 9834f57 into main Feb 21, 2024
10 checks passed
@aduh95 aduh95 deleted the lkf-ENOENT branch February 21, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.25.0 crashes with ENOENT on fresh install
3 participants