feat: add node v15.0.0 #1372
feat: add node v15.0.0 #1372
Conversation
|
@ttshivers any idea why it generates double builds?
|
|
I think it's fine to bump up to 3.12 as the default, but I'd probably keep 3.10 and 3.11 since they appear to be supported for the v15 lifetime https://wiki.alpinelinux.org/wiki/Alpine_Linux:Releases |
|
Might also make sense to keep around stretch https://www.debian.org/releases/. It seems like it is covered by LTS (although not by security?) https://www.debian.org/releases/stretch/ |
| array_14='14 latest current' | ||
| array_14='14' | ||
| # shellcheck disable=SC2034 | ||
| array_15='15 latest current' |
There was a problem hiding this comment.
I can't remember what the difference is for latest vs current. I know current comes from https://github.com/nodejs/Release, but I don't remember where latest comes from
There was a problem hiding this comment.
latest is a docker thing - what you get if you don't specify a tag (like npm/yarn does)
Any reason the keep them? Even though 15 will only be around for 6 months so it's not as painful as it'd be for v16 |
|
I'd keep
|
|
Unofficial build is out if anybody's by a computer and can update |
|
@nschonni re-added old distros |
| && case "${dpkgArch##*-}" in \ | ||
| amd64) ARCH='x64';; \ | ||
| ppc64el) ARCH='ppc64le';; \ | ||
| s390x) ARCH='s390x';; \ |
There was a problem hiding this comment.
Don't think it's worth trying to work around removing these in the template. I think stripping them from the architectures is good enough
There was a problem hiding this comment.
huh? you want me to remove s390x?
There was a problem hiding this comment.
No, I'm just pointing out that we still have it embed here, but since you removed it from the architectures at least it won't get built/tagged
There was a problem hiding this comment.
it's 1 AM here, so I'm heading to bed. Feel free to make any changes you want and land it, I just want v15 out 🙂
There was a problem hiding this comment.
No, I'm just pointing out that we still have it embed here, but since you removed it from the
architecturesat least it won't get built/tagged
I've just copied 14 and ran ./update.sh and rolled back the changes to 10 and 12, so whatever architectures we have there is duplicated in this new version
|
Created PR on the official-images repo (docker-library/official-images#8924). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
|
Quick bot! We should probably set it up to wait for the test builds (https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/), but no matter 🙂 |
| @@ -1,4 +1,4 @@ | |||
| baseuri https://nodejs.org/dist | |||
| default_variant stretch | |||
| alpine_version 3.11 | |||
| default_variant buster | |||
There was a problem hiding this comment.
Ah, looking at the stackbrew diff I now see what you meant here @nschonni. I wanted to change the default for v15, not the other versions. Should we change it back but overwrite for v15?
There was a problem hiding this comment.
Ah, yeah that would make sense
There was a problem hiding this comment.
I don't know bash enough to be able to fix get_config to allow being overwritten by a local file
There was a problem hiding this comment.
@nodejs/docker anyone with bash-fu up for fixing it? If not I recommend rolling back the config changes so we can land it. 15.0.1 is out as well, fwiw
|
Do i386 builds work for node 15? I remember reading that they might. |
|
I don't think so, since the PR is still open nodejs/node#33044 |
https://nodejs.org/en/blog/release/v15.0.0/
We need to wait for the unofficial build: https://unofficial-builds.nodejs.org/download/release/v15.0.0/
I went with just buster and alpine 3.12 instead of keeping the others around. Happy to re-add if people think that's a good idea