Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labels: add url-whatwg labels for WHATWG URL PRs #115

Merged
merged 1 commit into from Jan 12, 2017
Merged

labels: add url-whatwg labels for WHATWG URL PRs #115

merged 1 commit into from Jan 12, 2017

Conversation

joyeecheung
Copy link
Member

@targos
Copy link
Member

targos commented Jan 5, 2017

Can you also change line 24 for the C++ files?

@targos
Copy link
Member

targos commented Jan 5, 2017

Maybe we should stop labeling them url too. /cc @jasnell

@joyeecheung
Copy link
Member Author

@targos I'm +1 on stop labeling them url. Just see what others think.

@mscdex
Copy link
Contributor

mscdex commented Jan 5, 2017

Yes, I would definitely say one label or the other. It makes it much more explicit. Also that way if some change/issue should affect both implementations, we can use both labels and it will be clear/make sense.

@joyeecheung
Copy link
Member Author

Updated to remove the url labels.

targos

This comment was marked as off-topic.

Sign in to view

@joyeecheung joyeecheung mentioned this pull request Jan 11, 2017
Closed
4 tasks
@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2017

LGTM

@phillipj phillipj merged commit 3f881a2 into nodejs:master Jan 12, 2017
@phillipj
Copy link
Member

Thanks! This is live 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joyeecheung @targos @mscdex @phillipj