fix: failed to detect flavor if compiler path include white spaces #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This two windows CI failed with different errors, seems have nothing to do with changes in this PR. https://github.com/nodejs/gyp-next/actions/runs/8523184021/job/23344932415 |
cclauss
reviewed
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
cclauss
approved these changes
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Apr 2, 2024
2 tasks
legendecas
approved these changes
Apr 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up optimization to #222.
In previous implementation of
GetCrossCompilerPredefines, ifCC_targetinclude white space"/Users/Toyo Li/wasi-sdk/bin/clang"the cmd passed to
subprocess.Popenis incorrect:['"/Users/Toyo', 'Li/wasi-sdk/bin/clang"', ...]This PR fixed this issue, and will raise error if process exit code is not 0.