Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to detect flavor if compiler path include white spaces #240

Merged
merged 12 commits into from
Apr 23, 2024
Merged

fix: failed to detect flavor if compiler path include white spaces #240

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4c049a0
fix: failed to detect flavor if compiler path include white spaces
toyobayashi Apr 2, 2024
b6b68d6
raise error if exit code is not 0
toyobayashi Apr 2, 2024
50fd4ca
fix ruff lint
toyobayashi Apr 2, 2024
432a6dd
pipe stderr
toyobayashi Apr 2, 2024
3781700
fix test
toyobayashi Apr 2, 2024
3945b0d
os.sep
toyobayashi Apr 2, 2024
86a37ba
ruff --select=PT pylib/gyp/common_test.py
toyobayashi Apr 2, 2024
3689451
use subprocess.run
toyobayashi Apr 2, 2024
1bae115
ruff --select=SIM300 pylib/gyp/common_test.py
toyobayashi Apr 2, 2024
9e85fa3
fix: emcc may print additional info at the first
toyobayashi Apr 2, 2024
b0a7607
Apply suggestions from code review
toyobayashi Apr 2, 2024
d03f52d
remove unused continue
toyobayashi Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pylib/gyp/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,9 @@ def replace_sep(s):
defines = {}
lines = stdout.decode("utf-8").replace("\r\n", "\n").split("\n")
for line in lines:
if not line:
if not line or not line.startswith("#define "):
toyobayashi marked this conversation as resolved.
Show resolved Hide resolved
continue
cclauss marked this conversation as resolved.
Show resolved Hide resolved
define_directive, key, *value = line.split(" ")
assert define_directive == "#define"
_, key, *value = line.split(" ")
defines[key] = " ".join(value)
toyobayashi marked this conversation as resolved.
Show resolved Hide resolved
return defines

Expand Down
Loading