Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Rename primary branch to main. #502

Closed
mhdawson opened this issue May 27, 2021 · 12 comments
Closed

Rename primary branch to main. #502

mhdawson opened this issue May 27, 2021 · 12 comments
Labels
crowdin help wanted Extra attention is needed

Comments

@mhdawson
Copy link
Member

mhdawson commented May 27, 2021

We are going through all of the node.js repositories to rename the primary branch to main. Please see nodejs/node#33864 for more context.

I also don't see any references to master in githbub workflows so I don't think there should be issues with the rename.

Please let me know if there are any concerns otherwise I'll look to do the rename Friday May 4th.

@TiagoDanin TiagoDanin added crowdin help wanted Extra attention is needed labels May 28, 2021
@TiagoDanin
Copy link
Contributor

Required branch change in Crowdin.

CC @obensource @zeke

@zeke
Copy link
Contributor

zeke commented Jun 2, 2021

It appears that this repository is still being synced with Crowdin using Crowdin's OAuth-based GitHub integration.

That integration is owned (and can only be updated) by the @nodejs-crowdin GitHub user.

Screen Shot 2021-06-01 at 9 41 20 PM

We could potential solve two "problems" at once here by switching from the Oauth integration to the newer, preferred, GitHub-Actions powered integration: https://github.com/crowdin/github-action -- that would make the sync process codified in the repo for all to see, rather than tucked away in a GitHub integration that very few people know about or have access to.

That said, a new Actions-based integration would still need to be set up with the @nodejs-crowdin GitHub user, which exists for this specific purpose (syncing files between GitHub and Crowdin).

Are @obensource and I the only folks in the working group who have access to that bot account's credentials?

@mhdawson
Copy link
Member Author

@obensource want to sync to see how to move this forward.

@Andrulko
Copy link
Contributor

@obensource @mhdawson If you decide to rename the branch from master to main in this repository, please rename master in Crowdin project first of all, otherwise the existing master will be removed from Crowdin after renaming

srl295 added a commit to nodejs/full-icu-npm that referenced this issue Oct 4, 2021
also rename top of readme from `full-icu-npm` to `full-icu` to match the package name.

Ref: nodejs/i18n#502
srl295 added a commit to nodejs/full-icu-npm that referenced this issue Oct 4, 2021
also rename top of readme from `full-icu-npm` to `full-icu` to match the package name.

Ref: nodejs/i18n#502
srl295 added a commit to nodejs/full-icu-npm that referenced this issue Oct 4, 2021
also rename top of readme from `full-icu-npm` to `full-icu` to match the package name.

Ref: nodejs/i18n#502
@mhdawson
Copy link
Member Author

@obensource can you do the rename for crowdin? We are done to a small set of repos that need the rename to be completed and this is one of them.

@mhdawson
Copy link
Member Author

mhdawson commented May 2, 2022

@srl295 do you know who is still active and might do the crowdin part?

@mhdawson
Copy link
Member Author

mhdawson commented May 9, 2022

@zeke. @rvagg can you add my key to https://github.com/nodejs-private/secrets/tree/master/i18n so I could try to log in and do the requested rename in crowdin before renaming the primary branch.

@mhdawson
Copy link
Member Author

mhdawson commented May 9, 2022

or even better @zeke if you could help do the rename when I rename the primary branch that would be even better.

@mhdawson
Copy link
Member Author

We discussed in the TSC meeting and I got agreement we should rename as I've not been able to get any help/response in terms of fixing up crowdin first. If there is somebody that can help to fix that up after the rename let me know.

@mhdawson
Copy link
Member Author

Renamed

@JohnTitor
Copy link
Member

@alexandrtovmach 👋 Could you take a look at the settings on Crowdin if you have some time?

@Andrulko
Copy link
Contributor

Andrulko commented May 27, 2022

The master was renamed to main in advance in the project:
https://crowdin.com/project/nodejs/zh-CN

The only remaining item - you need to re-connect the integration via Integrations -> GitHub or adjust GHA script if it's used.

Note that it's totally safe to delete the integration and set it up again:
https://crowdin.com/project/nodejs/apps/system/github

The only requirement - it should be configured by GitHub user with admin access to the repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crowdin help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants