doc: add collaborator guide #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/diagnostics @nodejs/post-mortem @nodejs/llnode |
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 80.84% 73.44% -7.41%
==========================================
Files 33 33
Lines 4120 4120
==========================================
- Hits 3331 3026 -305
- Misses 789 1094 +305
Continue to review full report at Codecov.
|
cjihrig
approved these changes
Mar 5, 2019
COLLABORATOR_GUIDE.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| # llnode Collaborator Guide | |||
|
|
|||
| llnode follows | |||
There was a problem hiding this comment.
"follows" -> "follows the"?
richardlau
approved these changes
Mar 5, 2019
mmarchini
force-pushed
the
collaborator-guide-2
branch
from
43a33c1
to
68e9b46
Compare
llnode has been unofficially following the Node.js Collaborator Guide wrt Approving and Landing PRs policy. This commit adds COLLABORATOR_GUIDE.md with a link to Node.js Collaborator Guide, so we'll start to follow these guidelines officially. Fixes: nodejs#242
mmarchini
force-pushed
the
collaborator-guide-2
branch
from
68e9b46
to
cbb18b3
Compare
mmarchini
added a commit
that referenced
this pull request
Sep 10, 2019
llnode has been unofficially following the Node.js Collaborator Guide wrt Approving and Landing PRs policy. This commit adds COLLABORATOR_GUIDE.md with a link to Node.js Collaborator Guide, so we'll start to follow these guidelines officially. Fixes: #242 PR-URL: #275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 99d06e7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llnode has been unofficially following the Node.js Collaborator Guide
wrt Approving and Landing PRs policy. This commit adds
COLLABORATOR_GUIDE.md with a link to Node.js Collaborator Guide, so
we'll start to follow these guidelines officially.
Fixes: #242