fix: bump nmv version down, add dummy sig

nodejs · Oct 10, 2022 · 888ed50 · 888ed50
1 parent 7f9ceb8
commit 888ed50
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/nan.h b/nan.h
@@ -2550,7 +2550,7 @@ NAN_DEPRECATED inline void SetAccessor(
     , obj
     , settings
     , attribute
-#if (NODE_MODULE_VERSION < NODE_18_0_MODULE_VERSION)
+#if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
     , signature
 #endif
   );

diff --git a/nan_callbacks.h b/nan_callbacks.h
@@ -52,8 +52,10 @@ typedef void(*IndexQueryCallback)(
     const PropertyCallbackInfo<v8::Integer>&);
 
 namespace imp {
-#if (NODE_MODULE_VERSION < NODE_18_0_MODULE_VERSION)
-NAN_DEPRECATED typedef v8::Local<v8::AccessorSignature> Sig;
+#if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
+typedef v8::Local<v8::AccessorSignature> Sig;
+#else
+typedef v8::Local<v8::Data> Sig;
 #endif
 
 static const int kDataIndex =                    0;