Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we lower-case the Nan namespace? #385

Closed
rvagg opened this issue Jul 29, 2015 · 3 comments
Closed

Should we lower-case the Nan namespace? #385

rvagg opened this issue Jul 29, 2015 · 3 comments

Comments

@rvagg
Copy link
Member

rvagg commented Jul 29, 2015

I'm starting to think that using Nan isn't going to be idiomatic to a lot of people and perhaps we should be opting for nan instead for v2.

Of course I don't want this to hold up progress on getting a release out and I'd love a release within the next day or so, pending documentation being completed, but I also don't want us to be stuck with a decision we regret.

Thoughts @kkoopa, @bnoordhuis, @agnat?

@bnoordhuis
Copy link
Member

nan probably conflicts with the function of the same name from <math.h>.

@kkoopa
Copy link
Collaborator

kkoopa commented Jul 29, 2015

Exactly. The current form is the only one without conflicts.

On July 29, 2015 3:31:02 PM EEST, Ben Noordhuis notifications@github.com wrote:

nan probably conflicts with the function of the same name from
<math.h>.


Reply to this email directly or view it on GitHub:
#385 (comment)

@rvagg
Copy link
Member Author

rvagg commented Jul 29, 2015

(I feel like I've had this discussion before, sorry for being forgetful if that's the case)

@rvagg rvagg closed this as completed Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants