Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Node 7 #623

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Test on Node 7 #623

merged 1 commit into from
Nov 3, 2016

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Nov 3, 2016

edit: does this even make sense here? I basically wanted to duplicate the commit for Node 6, but since @nodejs doesn’t have Travis enabled, I’m not so sure anymore…

@brodycj
Copy link

brodycj commented Nov 3, 2016

This repo does have Travis and Appveyor enabled with status included in the README. The test on Node 7 already passes on Linux and Windows.

@addaleax
Copy link
Member Author

addaleax commented Nov 3, 2016

Huh. Right. Weird, I thought that wasn’t possible for some reason (but maybe that is only about new repositories). Thanks for pointing it out to silly me!

@kkoopa
Copy link
Collaborator

kkoopa commented Nov 3, 2016

Looks good. It's the github hooks that are not allowed, which is why the CI status does not show in pull requests or elsewhere you might expect to see it.

On November 4, 2016 12:00:43 AM GMT+02:00, Anna Henningsen notifications@github.com wrote:

Huh. Right. Weird, I thought that wasn’t possible for some reason (but
maybe that is only about new repositories). Thanks for pointing it out
to silly me!

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#623 (comment)

@kkoopa kkoopa merged commit b3b1e93 into nodejs:master Nov 3, 2016
@addaleax addaleax deleted the ci-node-7 branch November 3, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants