Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of deprecated IsNearDeath #842

Merged
merged 1 commit into from
Mar 24, 2019
Merged

remove usage of deprecated IsNearDeath #842

merged 1 commit into from
Mar 24, 2019

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Mar 15, 2019

Remove use of PersistentBase::IsNearDeath() as it has been deprecated in V8 and it would causes compilation warnings in Node.JS 12.

I have not added any ifdefs here as it was used only within asserts.

Refs: nodejs/node#26630

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure appears to be infrastructural (fails to download headers.)

@nolanmar511
Copy link
Contributor

I would love to see this change merged into master (if possible).

PersistentBase::IsNearDeath() has been removed in the version of v8 used in the v8-canary build of Node 12, and it would be nice to be able to test with the v8-canary build with the version of nan that can be installed from github.

@bnoordhuis
Copy link
Member

@kkoopa See above. Do you want to do a release for this? It's an otherwise harmless change.

@kkoopa
Copy link
Collaborator

kkoopa commented Mar 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants