Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of deprecated IsNearDeath #842

Merged
merged 1 commit into from Mar 24, 2019

Conversation

@Flarna
Copy link
Member

commented Mar 15, 2019

Remove use of PersistentBase::IsNearDeath() as it has been deprecated in V8 and it would causes compilation warnings in Node.JS 12.

I have not added any ifdefs here as it was used only within asserts.

Refs: nodejs/node#26630

Copy link
Member

left a comment

LGTM. CI failure appears to be infrastructural (fails to download headers.)

@nolanmar511

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

I would love to see this change merged into master (if possible).

PersistentBase::IsNearDeath() has been removed in the version of v8 used in the v8-canary build of Node 12, and it would be nice to be able to test with the v8-canary build with the version of nan that can be installed from github.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@kkoopa See above. Do you want to do a release for this? It's an otherwise harmless change.

@kkoopa

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

@kkoopa kkoopa merged commit fbaf422 into nodejs:master Mar 24, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
@Flarna Flarna deleted the Flarna:no-isneardeath branch Mar 24, 2019
@richardlau richardlau referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.