Add Node 19 to CI and update README #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new npm command `rebuild-tests-2017` with flag `msvs_version` set to 2017 - Change build image of AppVeyor to `Visual Studio 2017` This is due to Node 19's usage of a c++17 feature: 'static_assert' with no message
|
The Appveyor build passes. The Travis stack has not worked in years since they changed something with quotas and OS projects. Thank you, this looks excellent. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes: set build image of AppVeyor CI to Visual Studio 2017
This is mainly because of some usages of c++17 features in Node 19 headers.
Since I have no access to the Travis CI logs, I am not sure whether the CI passes in Travis.