-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Management #260
Comments
Agreed. Everything in the C n_api should be usable through node-addon-api, we just have not gotten them all in. Would be great if you add it in. |
@mhdawson @gabrielschulhof I'm starting on this. I want add a function on Napi namespace as reported below: int64_t AdjustExternalMemory(napi_env env, int64_t change_in_bytes); This is the same approach that I found on NAN. |
It is an interesting question as we don't have any other Utility classes, and adding the method to any of the existing classes does not make sense to me. At this point your suggestion seems like the best idea to me. |
@mhdawson Thanks for your opinion later I will provide to add it with corresponding tests and documentation. |
I close the issue because the PR with the feature was landed. |
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Hi everyone,
in my recent porting I had the need of using
napi_adjust_external_memory
See: https://nodejs.org/dist/latest/docs/api/n-api.html#n_api_memory_management . What do you think if we add this function to node-addon-api? if you are agree I want try to add the function with some guide.The text was updated successfully, but these errors were encountered: