src: interject class TypeTaggable #1298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
requested review from
NickNaso,
legendecas,
KevinEady and
mhdawson
gabrielschulhof
force-pushed
the
1293-allow-type-tagging-of-external
branch
from
3149002
to
016cac8
Compare
Derive class `TypeTaggable` from `Value`, and let it serve as the base class for `Object` and `External`. That way, the type tagging is implemented for both classes. Additionally, exclude deleted .js files from linting. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> Refs: nodejs#1293
gabrielschulhof
force-pushed
the
1293-allow-type-tagging-of-external
branch
from
016cac8
to
f78e0c5
Compare
legendecas
approved these changes
Mar 23, 2023
|
Test results: |
mhdawson
pushed a commit
that referenced
this pull request
Mar 27, 2023
Derive class `TypeTaggable` from `Value`, and let it serve as the base class for `Object` and `External`. That way, the type tagging is implemented for both classes. Additionally, exclude deleted .js files from linting. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> Refs: #1293 PR-URL: #1298 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed as d013044 |
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Derive class `TypeTaggable` from `Value`, and let it serve as the base class for `Object` and `External`. That way, the type tagging is implemented for both classes. Additionally, exclude deleted .js files from linting. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> Refs: nodejs/node-addon-api#1293 PR-URL: nodejs/node-addon-api#1298 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive class
TypeTaggablefromValue, and let it serve as the base class forObjectandExternal. That way, the type tagging is implemented for both classes.Refs: #1293