-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI configs #257
Update CI configs #257
Conversation
https://travis-ci.org/kfarnung/node-addon-api The matrix is pretty large now, I'm open to suggestions for reductions. |
We actually run the tests across platforms here: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api/ Right now we run master nightly, and the others when we create releases. We should at least document that there are 2 places to look, if not try to cover them both in the community CI. |
I wasn't aware of that, I just had Travis-CI setup for my fork and it was failing for a while. Does the that CI run include older versions of node as well? |
I think it's either worth landing these changes or deleting the files. Do we have any node-addon-api CI coverage for ChakraCore in the official CI? |
If you mean in the official CI for the n-api tests, no. I assume it would be a clone of the existing job, with possibly a smaller set of supported platforms, and then have it pull the chakra published versions. It does depend on binaries being already built/available. |
We do have official builds: https://nodejs.org/download/chakracore-release/ For platforms we currently support Windows (x86 and x64), macOS (x64), and Linux (x64). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will land and we can continue to discuss how to improve testing.
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: #257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed as 12b2cde |
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: nodejs/node-addon-api#257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: nodejs/node-addon-api#257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: nodejs/node-addon-api#257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: nodejs/node-addon-api#257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix missing `pip` in macOS builds Add new builds to the matrix PR-URL: nodejs/node-addon-api#257 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
pip
in macOS builds