objectwrap: implement missing descriptor definitions for symbols #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements descriptor definitions with symbols for `StaticMethod`, `StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`. Ref: nodejs#279
|
Thanks for the PR, will try to review soon. |
|
Sorry it took so long landed as 0a00e7c. As part of that updated to address errors due to the recent tightening of warnings. Also added doc for the new methods which we will be asking for going forward now that doc is complete in terms of existing coverage. |
|
No problem and thanks for adding missing documentation. |
DaAitch
deleted the
feature/279-objectwrap-except-InstanceMethod-no-descriptor-function-supports-symbol-as-name
branch
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Implements descriptor definitions with symbols for `StaticMethod`, `StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`. Ref: nodejs/node-addon-api#279 PR-URL: nodejs/node-addon-api#280 Refs: nodejs/node-addon-api#279 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Implements descriptor definitions with symbols for `StaticMethod`, `StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`. Ref: nodejs/node-addon-api#279 PR-URL: nodejs/node-addon-api#280 Refs: nodejs/node-addon-api#279 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Implements descriptor definitions with symbols for `StaticMethod`, `StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`. Ref: nodejs/node-addon-api#279 PR-URL: nodejs/node-addon-api#280 Refs: nodejs/node-addon-api#279 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Implements descriptor definitions with symbols for `StaticMethod`, `StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`. Ref: nodejs/node-addon-api#279 PR-URL: nodejs/node-addon-api#280 Refs: nodejs/node-addon-api#279 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements descriptor definitions with symbols for
StaticMethod,StaticAccessor,InstanceAccessor,StaticValue,InstanceValue.Ref: #279