Update from upstream #295
Closed
Update from upstream #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
update-from-upstream
branch
from
30a7ae0
to
b946ba1
Compare
added 6 commits
July 11, 2018 17:45
This backports e41ccd4e2de6deb03e277fa9d6baff685ab31689.
This backports 978d89f5e3cf238a0e42303acc9493993ede9c98.
This backports 2a08925896872c345e2948778eab01e9853c22cb.
Some changes needed for v4.x support. This backports c1695d8bad09fc61922ec91101736debb2d165db.
open_callback_scopes of napi_env cannot be backported. This backports 9e226475e8e28b8664643d6644503ccd06bceb9a
This backports 1a5a19d6d475578eec355a8b3079b4a96fc77489.
gabrielschulhof
force-pushed
the
update-from-upstream
branch
from
b946ba1
to
d23bbc4
Compare
|
I assume this was needed as you were using a version of Node.js 6.x, 8.x, 10.x which was earlier than when N-API was backported to those lines? |
|
Yeah, as long as there are supported versions of Node.js where we must build an out-of-tree copy of N-API, we should have these fixes. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Jul 12, 2018
The following commits are backported: e41ccd4e2de6deb03e277fa9d6baff685ab31689 - performance fix 2a08925896872c345e2948778eab01e9853c22cb - performance fix follow-up 978d89f5e3cf238a0e42303acc9493993ede9c98 - make functions gc-able c1695d8bad09fc61922ec91101736debb2d165db - add napi_fatal_exception() 9e226475e8e28b8664643d6644503ccd06bceb9a - exception handling fix 1a5a19d6d475578eec355a8b3079b4a96fc77489 - crash fix PR-URL: #295 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 9816197. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
The following commits are backported: e41ccd4e2de6deb03e277fa9d6baff685ab31689 - performance fix 2a08925896872c345e2948778eab01e9853c22cb - performance fix follow-up 978d89f5e3cf238a0e42303acc9493993ede9c98 - make functions gc-able c1695d8bad09fc61922ec91101736debb2d165db - add napi_fatal_exception() 9e226475e8e28b8664643d6644503ccd06bceb9a - exception handling fix 1a5a19d6d475578eec355a8b3079b4a96fc77489 - crash fix PR-URL: nodejs/node-addon-api#295 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
The following commits are backported: e41ccd4e2de6deb03e277fa9d6baff685ab31689 - performance fix 2a08925896872c345e2948778eab01e9853c22cb - performance fix follow-up 978d89f5e3cf238a0e42303acc9493993ede9c98 - make functions gc-able c1695d8bad09fc61922ec91101736debb2d165db - add napi_fatal_exception() 9e226475e8e28b8664643d6644503ccd06bceb9a - exception handling fix 1a5a19d6d475578eec355a8b3079b4a96fc77489 - crash fix PR-URL: nodejs/node-addon-api#295 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
The following commits are backported: e41ccd4e2de6deb03e277fa9d6baff685ab31689 - performance fix 2a08925896872c345e2948778eab01e9853c22cb - performance fix follow-up 978d89f5e3cf238a0e42303acc9493993ede9c98 - make functions gc-able c1695d8bad09fc61922ec91101736debb2d165db - add napi_fatal_exception() 9e226475e8e28b8664643d6644503ccd06bceb9a - exception handling fix 1a5a19d6d475578eec355a8b3079b4a96fc77489 - crash fix PR-URL: nodejs/node-addon-api#295 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
The following commits are backported: e41ccd4e2de6deb03e277fa9d6baff685ab31689 - performance fix 2a08925896872c345e2948778eab01e9853c22cb - performance fix follow-up 978d89f5e3cf238a0e42303acc9493993ede9c98 - make functions gc-able c1695d8bad09fc61922ec91101736debb2d165db - add napi_fatal_exception() 9e226475e8e28b8664643d6644503ccd06bceb9a - exception handling fix 1a5a19d6d475578eec355a8b3079b4a96fc77489 - crash fix PR-URL: nodejs/node-addon-api#295 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport performance improvements, function instantiation, and exception propagation from upstream