-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix some Finalizer
signatures
#414
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- External::New - ArrayBuffer::New - Buffer::New Ref: nodejs#384 Fixes: nodejs#383
question: |
Okay, seems to be dicussed here 😆 #368 |
mhdawson
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed as fa49d68 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
- External::New - ArrayBuffer::New - Buffer::New PR-URL: nodejs/node-addon-api#414 Fixes: nodejs/node-addon-api#383 Refs: nodejs/node-addon-api#384 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
- External::New - ArrayBuffer::New - Buffer::New PR-URL: nodejs/node-addon-api#414 Fixes: nodejs/node-addon-api#383 Refs: nodejs/node-addon-api#384 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
- External::New - ArrayBuffer::New - Buffer::New PR-URL: nodejs/node-addon-api#414 Fixes: nodejs/node-addon-api#383 Refs: nodejs/node-addon-api#384 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
austinli64
added a commit
to austinli64/node-addon-api
that referenced
this pull request
May 9, 2023
- External::New - ArrayBuffer::New - Buffer::New PR-URL: nodejs/node-addon-api#414 Fixes: nodejs/node-addon-api#383 Refs: nodejs/node-addon-api#384 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
- External::New - ArrayBuffer::New - Buffer::New PR-URL: nodejs/node-addon-api#414 Fixes: nodejs/node-addon-api#383 Refs: nodejs/node-addon-api#384 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #384
Fixes: #383