Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncWorker: make callback optional #489

Closed
wants to merge 1 commit into from
Closed

AsyncWorker: make callback optional #489

wants to merge 1 commit into from

Commits on Jun 13, 2019

  1. AsyncWorker: make callback optional 

    `AsyncWorker` assumed that after work is complete,  a JavaScript
 callback would need to execute.

This change removes the restriction of specifying a `Function` callback,
and instead replaces it with an `Env` parameter. Since the purpose of
`receiver` was for the `this` context for the callback, it has also been
removed from the constructors.

Re: nodejs#231 (comment)
    @KevinEady
    KevinEady committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    1159aeb View commit details
    Browse the repository at this point in the history