AsyncWorker: make callback optional #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Jun 10, 2019
napi-inl.h
Outdated
| @@ -3522,6 +3522,32 @@ inline AsyncWorker::AsyncWorker(const Object& receiver, | |||
| NAPI_THROW_IF_FAILED_VOID(_env, status); | |||
| } | |||
|
|
|||
| inline AsyncWorker::AsyncWorker(napi_env env) | |||
There was a problem hiding this comment.
These should be Napi::Env env as opposed to napi_env env for consistency with the rest of the API. Same goes for other places env is being added.
There was a problem hiding this comment.
Thanks for the tip. I was a little confused because several places use napi_env but maybe those are older pieces of code. Changed now to Napi::Env
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs#231 (comment)
KevinEady
force-pushed
the
asyncworker-opt-cb
branch
from
1b0aa83
to
1159aeb
Compare
mhdawson
pushed a commit
that referenced
this pull request
Jun 18, 2019
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: #231 (comment) PR-URL: #489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed as b2b0812 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs/node-addon-api#231 (comment) PR-URL: nodejs/node-addon-api#489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs/node-addon-api#231 (comment) PR-URL: nodejs/node-addon-api#489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs/node-addon-api#231 (comment) PR-URL: nodejs/node-addon-api#489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
austinli64
added a commit
to austinli64/node-addon-api
that referenced
this pull request
May 9, 2023
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs/node-addon-api#231 (comment) PR-URL: nodejs/node-addon-api#489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: nodejs/node-addon-api#231 (comment) PR-URL: nodejs/node-addon-api#489 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncWorkerassumed that after work is complete, a JavaScript callback would need to execute.This change removes the restriction of specifying a
Functioncallback, and instead replaces it with anEnvparameter. Since the purpose ofreceiverwas for thethiscontext for the callback, it has also been removed from the constructors.Re: #231 (comment)