Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code format in tests #617

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@tniessen
Copy link
Member

tniessen commented Dec 1, 2019

This fixes a few code formatting issues in test/.

@tniessen tniessen added the test label Dec 1, 2019
@legendecas

This comment has been minimized.

Copy link
Member

legendecas commented Dec 1, 2019

Maybe linters can be introduced to the project?

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Dec 1, 2019

That is generally a good idea!

@NickNaso

This comment has been minimized.

Copy link
Member

NickNaso commented Dec 2, 2019

We could use clang-format. We can install it like dev dependencies. What do you think?

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Dec 2, 2019

I have never used clang-format. Most Node.js projects use ESLint for the JS parts, and in core we use cpplint for C++. Seems like we also have a partial ruleset for clang-format, though.

Copy link
Member

mhdawson left a comment

LGTM

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Dec 5, 2019

I think this can land while we figure out if we can add linters.

Copy link
Member

legendecas left a comment

LGTM either the linters could be added in the PR or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.