Upgrade node-addon-api Object Wrap example for multi-context support

[anfilat]

It replaced global constructor with new SetInstanceData\GetInstanceData API.

[mhdawson]

I don't think we'd want to add this. If the example needs to be different for multi-context and that is only available in later Node.js versions, then we should add a new example versus changing the old one. Ideally we would have an example that would work across all Node.js LTS versions.

[anfilat]

Ok, I changed it and it a new example now. But there is linked bug nodejs/node-addon-api#730

[jschlight]

@anfilat There is a newer example of using ObjectWrap on this same examples repository that does not involve a static constructor function:

https://github.com/nodejs/node-addon-examples/tree/master/object-wrap-demo/node-addon-api

As far as I can tell, this newer example is context aware. Will you be able to meet your objectives by following the pattern of this newer example?

A question for the N-API team. In what cases is a static constructor function required? Or could it be the case that the 6_object_wrap napi and node-addon-api examples were simply a direct translation from the nan example and are no longer good examples to be promoting?

[anfilat]

@jschlight As I see, there is a similar PR from the N-API team member - #139

[jschlight]

@anfilat Thank you. I will followup with the N-API team.

[gabrielschulhof]

This needs to work with all supported versions of Node.js.

[gabrielschulhof]

@anfilat using the value for "engiens" as suggested at #139 (comment) should make the CI green, and it should actually test your code on Travis at least, even if it doesn't test it on GitHub actions.

[gabrielschulhof]

Oh, wait, #139 needs to land to update the .travis.yml removing the non-supported Node.js 8 first 🙂

[anfilat]

@gabrielschulhof I think I should close this PR. It's duplicate with #139 now

[qxred]

Seems this issues exists when using cmake-js (6.1.0) instead of gyp , can anyone help?