Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird weekend detection #215

Closed
targos opened this issue Mar 10, 2018 · 2 comments
Closed

Weird weekend detection #215

targos opened this issue Mar 10, 2018 · 2 comments
Labels
bug pr-checker Issues related to pr checker Priority: High Issues/Bugs the needs to be fixed quickly.

Comments

@targos
Copy link
Member

targos commented Mar 10, 2018

git node metadata 19203

...
ℹ  This PR was created on Wed Mar 07 2018 (weekend in UTC)
⚠  5 hours left to land
@priyank-p priyank-p added bug pr-checker Issues related to pr checker Priority: High Issues/Bugs the needs to be fixed quickly. labels Mar 10, 2018
@MM422
Copy link
Contributor

MM422 commented Mar 16, 2018

Hi, @targos I think it is actually caused by this line:

node-core-utils/lib/pr_checker.js

Line 134 in b94a608

const utcDay = now.getUTCDay();

In stead of using utcDay, we should use createTime to show whether that PR was created during weekends.

@cPhost I can create a PR to fix this bug if you want. I think the test cases also failed.

@priyank-p
Copy link
Contributor

@GithubGoldMiner go for it :)

@MM422 MM422 mentioned this issue Mar 17, 2018
Merged
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
lib: fix weekend detection
c2c21e6 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
@renawolford6
lib: fix weekend detection
b663995 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
@logictitans
lib: fix weekend detection
b24196d 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
@gerkai
lib: fix weekend detection
9499915 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
shovon58 pushed a commit to shovon58/node-core-utils that referenced this issue Jun 9, 2023
@paxaxel223
lib: fix weekend detection
187e222 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
@patrickm68
lib: fix weekend detection
89fe940 
* #215 Weird weekend detection fixed

PR-URL: nodejs/node-core-utils#220
Fixes: nodejs/node-core-utils#215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr-checker Issues related to pr checker Priority: High Issues/Bugs the needs to be fixed quickly.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @MM422 @priyank-p