Testing github intergrations

[joyeecheung]

This PR is for testing how we can bring the CI integrations back without granting third-party access to those services..

[codecov]

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          14       14           
  Lines         534      534           
=======================================
  Hits          486      486           
  Misses         48       48

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c42f35...4795f87. Read the comment docs.

[joyeecheung]

So..

• Travis builds
• Appveyor builds under joyeecheung/node-core-utils even though it's pulling code from this repo
• Code cov is reported

...(no idea how to bring snyk back)

but only the code-cov is able to report status to github? (Because I've installed the app into this repo?)

[Tiriel]

It may be a dumb question (you'll notice I have plenty of those), but isn't that precisely the purpose of the github-bot ?

The readme isn't that clear, but it seems to indicate it can be used to display travis reports.

[joyeecheung]

Progress: we need to use the github bot of the organization to post build status now, since we don't allow any third-party access to the nodejs organization except our own bots.

Refs: nodejs/nodejs.org#355
Refs: nodejs/citgm#102
Refs: https://github.com/nodejs/github-bot/blob/master/scripts/display-travis-status.js

Before I got the bot hooked into this repo we will need to go see the Travis & Appveyor status ourselves in https://travis-ci.org/nodejs/node-core-utils and https://ci.appveyor.com/project/joyeecheung/node-core-utils (yes it's under joyeecheung but it's actually triggered by activities in this repo because I've got the service hooks setup)

EDIT: yes basically what #100 (comment) says lol

[joyeecheung]

PR opened in nodejs/github-bot#156 . To fix appveyor we need to implement a new script in the bot...

[Tiriel]

Wasn't a dumb question after all then 😄

Awesome work!

[joyeecheung]

Uh, that's weird, the github bot deployed on my own server with my own token can update the status of this PR, but the github bot deployed in the foundation's server got 404 when it tries to pull_request.synchronize..

[joyeecheung]

Ah, I think I've got this working!

[joyeecheung]

Yes, it's working properly now. Next step is to implement the appveyor couterpart

[joyeecheung]

I am going to close this and open another one when I start implementing appveyor scripts