Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ncu-contrib: initial implementation #186

Closed
wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

Currently two types of contribution profiles are available:

  1. Participations (comments, reviews, PRs, opened issues, across the whole nodejs organization). The displayed result are the latest participations of the selected group.

screen shot 2018-02-21 at 7 44 02 am

  1. Commits (by default, commits on the master branch of nodejs/node). The displayed result are the latest commits of the selected group.

screen shot 2018-02-21 at 7 44 22 am

The group can be:

  1. collaborators
  2. tsc
  3. Array of GitHub handles
ncu-contrib <command>

Commands:
  ncu-contrib collaborators  Getting contributions from collaborators
  ncu-contrib tsc            Getting contributions from TSC members
  ncu-contrib for <ids..>    Getting contributions from GitHub handles

Options:
  --version  Show version number                                       [boolean]
  --help     Show help                                                 [boolean]
  --repo                                              [string] [default: "node"]
  --owner                                           [string] [default: "nodejs"]
  --type                                     [string] [default: "participation"]
  --branch                                          [string] [default: "master"]

@joyeecheung
Copy link
Member Author

Refs: nodejs/node#18879

This needs some tests to land...also I plan to reuse some bits of it to implement the nomination template proposed in nodejs/node#18090 (comment)

@alopezsanchez
Copy link
Contributor

Nice work!

I can do the tests if you give me a few days (I have not much time ATM).

@joyeecheung
Copy link
Member Author

@alopezsanchez Thanks, I'll first play with it for a few days to make sure this covers what I want as the initial implementation, then it'll be more ready to test. I still need to figure out how to make the cache work properly (I don't really think the users need them, they are mostly for developing and debugging)

@benjamingr
Copy link
Member

Very nice, who does it bring up at the moment as no activity in the last year?

@joyeecheung
Copy link
Member Author

Some feedback I've gathered:

  1. Need to add options to account for Reviewed-By fields in--type commit
  2. authoredDate -> committedDate in--type commit
  3. Would be nice if there are some percentiles

@benjamingr I have posted my findings in nodejs/node#18879 (comment) , don't want to post the names in public but I can send you a gist if you want to see the list.

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files          19       19           
  Lines         723      723           
=======================================
  Hits          640      640           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dafebf...d30abc5. Read the comment docs.

@codebytere
Copy link
Member

@joyeecheung do you think you still plan to work on this, or may it be closed as abandoned?

@github-actions
Copy link
Contributor

This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 29, 2020
@codebytere
Copy link
Member

Closing but if someone would like to pick this up again please reopen :)

@codebytere codebytere closed this Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants