Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bin: custom git commands #98

Closed
wants to merge 1 commit into from
Closed

[WIP] bin: custom git commands #98

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This implements a custom git command git node that automate the landing process.

1) To land single a commit:
   git node just <PRID>

2) To land multiple commits: 
   git node apply <PRID>
   git rebase -i upstream/master  # edit every commit that's gonna stay
   # on each stay
   git node ammend <PRID>
   git rebase --continue
   # when the rebase is done
   git node final

Still a WIP, trying to port everything into node scripts..

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          14       14           
  Lines         492      492           
=======================================
  Hits          483      483           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491e2b2...617a4a1. Read the comment docs.

@priyank-p priyank-p added the Work In Progress PR's that are in progress label Nov 9, 2017

echo "
1) To land single a commit:
git node just <PRID>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyeecheung just want to know am i mistaken or this should be git-node instead of git node
as we have git-node in package.json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git custom commands work like this: if you have an executable named "git-*" on your path, the it will be run when you do "git *"

@priyank-p
Copy link
Contributor

@joyeecheung this PR looks great! Great Work.

Copy link
Contributor

@Tiriel Tiriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way too cool.

Just setting my review to "comment" while you finish your wip.

@Tiriel Tiriel mentioned this pull request Nov 10, 2017
@Tiriel Tiriel added this to In Progress in Feature Requests Nov 10, 2017
@joyeecheung
Copy link
Member Author

Oh....I know why my pushed commits didn't show up here now, it's being merged from the branch here now that this repo has been transferred.....I'll close this and open another one from my fork.

@joyeecheung joyeecheung deleted the git-cmd branch November 11, 2017 04:45
@priyank-p priyank-p moved this from In Progress to Done in Feature Requests Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress PR's that are in progress
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants