Allow setting request's "ciphers" option #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for fix of atom/apm#647
Skehmatics
pushed a commit
to Skehmatics/apm
that referenced
this pull request
Jan 18, 2017
These settings get passed to any GET call from request and to node-gyp. nodejs/node-gyp#1091 needs to be pulled for this to actually work.
bnoordhuis
requested changes
Jan 18, 2017
lib/install.js
Outdated
| @@ -438,6 +438,12 @@ function download (gyp, env, url) { | |||
| requestOpts.ca = readCAFile(cafile) | |||
| } | |||
|
|
|||
| // Support for setting specific TLS ciphers | |||
| var cipherList = gyp.opts.ciphers | |||
| if (cipherList){ | |||
gibfahn
reviewed
Jan 19, 2017
lib/node-gyp.js
Outdated
| @@ -213,4 +214,3 @@ Object.defineProperty(proto, 'version', { | |||
| } | |||
| , enumerable: true | |||
| }) | |||
|
|
|||
Remove accidental edit. Development on windows strikes again!
|
stale? let us know if you want to pursue still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some corporate proxy setups require the use of very specific TLS cipher lists. This set's request's
options.agentOptions.ciphersproperty to a new node-gypciphersproperty to let the user choose the allowed TLS ciphers.