Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python info needs own header #1245

Merged
merged 4 commits into from Nov 26, 2018

Conversation

@TaylorDennisLee
Copy link
Contributor

commented Jun 30, 2017

There must be some kind of separation there in the Readme. It isn't clear this isn't part of the Windows installation information.

README.md Outdated
@@ -66,6 +66,8 @@ Install tools and configuration manually:

If the above steps didn't work for you, please visit [Microsoft's Node.js Guidelines for Windows](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules) for additional tips.

## Configuring Python Dependency

If you have multiple Python versions installed, you can identify which Python
version `node-gyp` uses by setting the '--python' variable:

This comment has been minimized.

Copy link
@richardlau

richardlau Jun 30, 2017

Member

Since we're editing, the quotes around --python could be fixed.

README.md Outdated
If you have multiple Python versions installed, you can identify which Python
version `node-gyp` uses by setting the '--python' variable:
version `node-gyp` uses by setting the "--python" variable:

This comment has been minimized.

Copy link
@gibfahn

gibfahn Jun 30, 2017

Member

I'm 99% sure @richardlau meant `--python`

This comment has been minimized.

Copy link
@TaylorDennisLee

TaylorDennisLee Jun 30, 2017

Author Contributor

My bad, will fix.

@refack
refack approved these changes Jun 30, 2017
@refack

This comment has been minimized.

Copy link
Member

commented Jun 30, 2017

Anyone knows if there is a POSIX equivalent to PEP514?

@refack

This comment has been minimized.

Copy link
Member

commented Jun 30, 2017

Ahhh H-E-double-hockey-sticks, I'm gonna do the gyp.js thing after the Holiday...

@cclauss

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

@refack Which holiday?

@refack

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

after the Holiday...

Which holiday?

Exactly 😞
Translated from Hebrew, after the Holiday means at a later unspecified date.

@refack refack merged commit 9dee52f into nodejs:master Nov 26, 2018
rvagg added a commit that referenced this pull request Apr 24, 2019
PR-URL: #1245
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.