Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: pin `request` to ~2.81.0 #1300

Closed
wants to merge 0 commits into from

Conversation

@refack
Copy link
Member

commented Sep 26, 2017

Checklist
Description of change

Required for "node < 4" compatibility and is congruent with npm

Fixes: #1299

@refack refack added npm v3.x labels Sep 26, 2017
Copy link
Member

left a comment

LGTM, although it's going to diverge (and more importantly: cause duplication) when npm upgrades to request 2.9.0.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Sep 26, 2017

Another thing, if we ever decide to upgrade the node-gyp in the v4.x and v6.x branches, that too would result in duplication: their copies of npm are stuck on request@2.75.0.

Not the end of the world, just something to keep in mind.

@refack

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Another thing, if we ever decide to upgrade the node-gyp in the v4.x and v6.x branches, that too would result in duplication: their copies of npm are stuck on request@2.75.0.

I'll test if <2.82.0 get npm to dedup...

@refack

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Indeed setting to <2.82.0 allows deduping:

$ npm ls | grep req
npm@2.15.12 d:\code\4node\test-npm-request\npm
| +-- request@2.74.0 deduped
| +-- request@2.74.0 deduped
+-- request@2.74.0
@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

@refack can you also give the minimum version in that specifier if you use <? I think right now you’d match any version of request before 2.82.0, up from 0.8.3 (which I assume does not work :))

@refack

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

I think right now you’d match any version of request before 2.82.0, up from 0.8.3 (which I assume does not work :))

Ack.
Did some bisecting - minimal version to pass npm test is 2.9.0.

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

thanks!

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

Ping @refack.

refack added a commit that referenced this pull request Oct 10, 2017
Required for "node < 4" compatibility and is congruent with `npm`

minimum for passing `npm test` >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: #1300
Fixes: #1299
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refack refack closed this Oct 10, 2017
@refack refack force-pushed the refack:ping-request-on3-branch branch from a60bd45 to 7900122 Oct 10, 2017
@edi9999

This comment has been minimized.

Copy link

commented Jan 15, 2018

@refack Could you please release of the 3.x with this change ?

@MissSheyni MissSheyni referenced this pull request Apr 5, 2018
4 of 4 tasks complete
@refack refack deleted the refack:ping-request-on3-branch branch Jun 14, 2018
rvagg added a commit that referenced this pull request Aug 9, 2018
Required for "node < 4" compatibility and is congruent with `npm`

minimum for passing `npm test` >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: #1300
Fixes: #1299
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg added a commit that referenced this pull request Apr 24, 2019
Required for "node < 4" compatibility and is congruent with `npm`

minimum for passing `npm test` >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: #1300
Fixes: #1299
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@rvagg rvagg referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.