Fix space in deps #1436
Closed
Fix space in deps #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spaces are not an unusual case, will this be merged? |
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 8, 2018
PR-URL: #1436 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
I'm not 100% positive this is going to catch all cases but it's still a step up. Landed in 1cf636b, thanks Jeff! |
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Jun 21, 2018
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch Refs: nodejs/node-gyp#1436
MylesBorins
added a commit
to nodejs/node
that referenced
this pull request
Jun 25, 2018
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: #21448 Refs: nodejs/node-gyp#1436 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
MylesBorins
added a commit
to nodejs/node
that referenced
this pull request
Jun 25, 2018
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: #21448 Refs: nodejs/node-gyp#1436 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 26, 2018
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: #21448 Refs: nodejs/node-gyp#1436 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 16, 2018
This is a fix for filenames that have spaces which currently breaks node-gyp. npm has not yet updated the dependency to the latest version in the mean time we should land this as a patch PR-URL: #21448 Refs: nodejs/node-gyp#1436 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesxxx- [ ] tests are included
(Note: I'm unsure how to test this case without a lengthy exercise)
Description of change
Fixes a narrow issue when spaces are found in paths in the computed dependencies of the Makefile. This occurs in the unusual circumstance that the username and/or home directory has a space