Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 asm #1679

Closed
wants to merge 1 commit into from

Conversation

@jkunkee
Copy link
Contributor

commented Feb 25, 2019

Checklist
  • npm install && npm test passes
  • tests are included
    • No GYP tests seem to be in node-gyp
  • commit message follows commit guidelines
Description of change

This is a port of nodejs/node#26020 (see also refack/GYP3#23) to the node-gyp copy of GYP. It is important when building Node.js itself (V8 has ASM bits; hence the other PR) and when building native modules with ASM (fairly rare, as I understand it).

@jkunkee jkunkee force-pushed the jkunkee:add-arm64-asm branch from 29998a3 to 96472fa Feb 25, 2019
@jkunkee jkunkee marked this pull request as ready for review Feb 25, 2019
@jkunkee

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

This is a much smaller change than #1678, but they may overlap some.

@jkunkee jkunkee referenced this pull request Mar 4, 2019
2 of 3 tasks complete
@jkunkee

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

This PR is redundant with upgrading node-gyp's GYP to refack/GYP.

@rvagg rvagg force-pushed the nodejs:master branch from 1456ef2 to 7a71d68 Apr 24, 2019
This change allows MSVS projects generated for ARM64 to include ASM
files.
@jkunkee jkunkee force-pushed the jkunkee:add-arm64-asm branch from 96472fa to d3b9c3e May 2, 2019
@jkunkee

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

#1678's GYP-specific parts were separated into refack/GYP3#33, then that was ported back as #1739. It might have a merge conflict with this PR, but they do not functionally overlap.

joaocgreis added a commit to JaneaSystems/node-gyp that referenced this pull request May 7, 2019
This change allows MSVS projects generated for ARM64 to include ASM
files.

PR-URL: nodejs#1679
Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.