Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: Support Visual Studio 2019 #1715

Closed
wants to merge 70 commits into from
Closed
Show file tree
Hide file tree
Changes from 69 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
5f924ce
Upgrade to tar v3
isaacs May 31, 2017
75cfae2
bump to v4.0.0
refack Jun 6, 2017
c84a541
configure: don't set ensure if tarball is set
gibfahn Jun 7, 2017
d6139b5
gyp: update xml string encoding conversion
lc-soft May 20, 2017
35e1dbb
doc: headerify the Install instructions
nschonni Jun 6, 2017
2e40fad
doc: update proposed DCO and CoC
mikeal Oct 14, 2015
7245415
doc: add github PR and Issue templates
gibfahn Jul 4, 2017
63f43c2
win: run PS with `-NoProfile`
refack Sep 14, 2017
a8ba528
zos: support platform
jBarz Sep 26, 2017
05d2002
Fix IndexError when parsing GYP files.
bnoordhuis Aug 19, 2017
6b68b60
Update README with another way to install on windows
JeffAtDeere Feb 18, 2018
57279a2
Update `--nodedir` description in README.
bnoordhuis Jan 27, 2018
8b7ccfe
Fix infinite install loop.
bnoordhuis Feb 26, 2018
3a52936
gyp: don't print xcodebuild not found errors
gibfahn Jan 21, 2018
91789c2
doc: update macOS information in README
josh- Jun 8, 2018
293092c
gyp: fix regex to match multi-digit versions
jhermsmeier Jun 5, 2018
02ac2e7
zos: add search locations for libnode.x
jBarz May 29, 2018
eaedc12
zos: don't use universal-new-lines mode
jBarz May 30, 2018
206309e
gyp: add support for .mm files to msvs generator
jracle Apr 7, 2017
4379c47
Prefix build targets with /t: on Windows
NatalieWolfe Apr 4, 2017
fbecb38
Fix include path when pointing to Node.js source
richardlau Nov 17, 2016
d70513a
Drop dependency on minimatch.
doowb Mar 27, 2017
1cf636b
gyp: escape spaces in filenames in make generator
May 10, 2018
50b8734
Remove unused gyp test scripts.
bnoordhuis Jun 8, 2018
c5e9802
doc: lint README.md
maclover7 Jul 19, 2018
6b0f4ae
bin,lib: remove extra comments/lines/spaces
maclover7 Jul 28, 2018
b2e5cf0
Add ESLint no-unused-vars rule
maclover7 Aug 2, 2018
25208f1
win: improve parsing of SDK version
Loghorn Jul 30, 2018
da5db40
configure: use sys.version_info to get python version
hashseed Jul 17, 2018
1309efb
doc: fix visual studio links
bzoz Jul 2, 2018
a0cf9d5
doc: update link to commit guidelines
jhermsmeier Jun 5, 2018
d9ee0ea
doc: update Xcode preferences tab name.
divan Nov 10, 2017
fb2d3a2
deps: pin `request` version range
refack Sep 26, 2017
baa0616
deps: bump request to 2.8.7, fixes heok/hawk issues
Rohithzr Jul 4, 2018
eb78b5a
test: added test/processExecSync.js for when execFileSync is not avai…
Rohithzr Jul 21, 2018
877b83b
test: formatting and minor fixes for execFileSync replacement
rvagg Aug 8, 2018
8ad9ecd
gyp: backport GYP fix to fix AIX shared suffix
Nov 14, 2016
a265040
gyp: float gyp patch for long filenames
addaleax May 27, 2016
5c2aad8
gyp: add compile_commands.json gyp generator
bnoordhuis Aug 5, 2016
6ffef51
gyp: enable cctest to use objects (gyp part)
danbev Oct 18, 2016
f739c18
gyp: implement LD/LDXX for ninja and FIPS
sam-github Jul 13, 2017
d8eac7a
tools: fix "the the" typos in comments
May 14, 2018
eebc8f6
tools: patch gyp to avoid xcrun errors
ryzokuken Jun 25, 2018
2ca32e0
gyp: fix ninja build failure (GYP patch)
danbev Apr 18, 2017
bac9e44
doc: update changelog
rvagg Aug 9, 2018
3481739
test: remove unused variable
joaocgreis Oct 11, 2018
c9276f3
gyp: get ready for python 3
Nov 14, 2017
73b5b63
gyp: use print as a function, as specified in PEP 3105.
rodrigc Mar 19, 2017
3321444
gyp: replace deprecated functions
rodrigc Mar 19, 2017
9eb9b39
gyp: replace basestring with str, but only on Python 3.
rodrigc Mar 19, 2017
ef8b60a
gyp: _winreg module was renamed to winreg in Python 3.
rodrigc Mar 19, 2017
ae0be87
gyp: fix sntex error
Nov 14, 2017
2394a1e
gyp: fix target --> self.target
Nov 14, 2017
1ef7709
deps: replace `osenv` dependency with native `os`
Siilwyn Oct 13, 2018
2b5ce52
bin: follow XDG OS conventions for storing data
Siilwyn Oct 13, 2018
aebdd7a
lib: use print() for python version detection
greenaddress Oct 20, 2018
e2401e1
tools: fix usage of inherited -fPIC and -fPIE
arrkiin Oct 20, 2018
3fcddce
win: fix delay-load hook for electron 4
adill Oct 22, 2018
6b7c8e6
python: more informative error
refack Aug 20, 2017
a6990ad
python: clean-up detection
joaocgreis Oct 24, 2018
9dee52f
doc: python info needs own header
TaylorDennisLee Nov 26, 2018
53b6074
doc: improve issue template
bzoz Nov 28, 2018
2349dba
gyp: move compile_commands_json
paul-marechal Feb 6, 2019
cfd4a9a
Add ARM64 to MSBuild /Platform logic
jkunkee Jan 25, 2019
8a26df0
readme: add ARM64 info to MSVC setup instructions
jkunkee Jan 25, 2019
83f8749
Remove an outdated workaround for Python 2.4
cclauss Jan 21, 2019
bb8b294
win: use msbuild from the configure stage
bzoz Feb 13, 2019
5fb19f5
test: fix addon test for Node.js 12 and V8 7.4
richardlau Apr 2, 2019
4b674a5
win: Support Visual Studio 2019
syohex Apr 9, 2019
29b0c2e
[fixup] Search newer Visual Studio first
syohex Apr 12, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
env:
node: true
es6: true
rules:
no-unused-vars: error
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<!--
Thank you for reporting an issue. The more information you can give us, the
better the chance we can fix your problem.

This issue tracker is for issues with node-gyp,
if you have an issue installing a specific module, please file an issue on
that module's issue tracker (`npm issues modulename`).
-->

* **Node Version**: <!-- `node -v` and `npm -v` -->
* **Platform**: <!-- `uname -a` (UNIX), or `systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type"` (Windows) -->
* **Compiler**: <!-- `cc -v` (UNIX) or `msbuild /version & cl` (Windows) -->
* **Module**: <!-- what you tried to build/install -->

<details><summary>Verbose output (from npm or node-gyp):</summary>

```
Paste your log here, between the backticks. It can be:
- npm --verbose output,
- or contents of npm-debug.log,
- or output of node-gyp rebuild --verbose.
```

</details>

<!-- Any further details -->

17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
Thank you for your pull request. Please review the below requirements.

Contributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `npm install && npm test` passes
- [ ] tests are included <!-- Bug fixes and new features should include tests -->
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

##### Description of change
<!-- Provide a description of the change -->

2 changes: 1 addition & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"asi": true,
"laxcomma": true,
"es5": true,
"esversion": 6,
"node": true,
"strict": false
}
51 changes: 51 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,54 @@
v3.8.0 2018-08-09
=================

* [[`c5929cb4fe`](https://github.com/nodejs/node-gyp/commit/c5929cb4fe)] - **doc**: update Xcode preferences tab name. (Ivan Daniluk) [#1330](https://github.com/nodejs/node-gyp/pull/1330)
* [[`8b488da8b9`](https://github.com/nodejs/node-gyp/commit/8b488da8b9)] - **doc**: update link to commit guidelines (Jonas Hermsmeier) [#1456](https://github.com/nodejs/node-gyp/pull/1456)
* [[`b4fe8c16f9`](https://github.com/nodejs/node-gyp/commit/b4fe8c16f9)] - **doc**: fix visual studio links (Bartosz Sosnowski) [#1490](https://github.com/nodejs/node-gyp/pull/1490)
* [[`536759c7e9`](https://github.com/nodejs/node-gyp/commit/536759c7e9)] - **configure**: use sys.version\_info to get python version (Yang Guo) [#1504](https://github.com/nodejs/node-gyp/pull/1504)
* [[`94c39c604e`](https://github.com/nodejs/node-gyp/commit/94c39c604e)] - **gyp**: fix ninja build failure (GYP patch) (Daniel Bevenius) [nodejs/node#12484](https://github.com/nodejs/node/pull/12484)
* [[`e8ea74e0fa`](https://github.com/nodejs/node-gyp/commit/e8ea74e0fa)] - **tools**: patch gyp to avoid xcrun errors (Ujjwal Sharma) [nodejs/node#21520](https://github.com/nodejs/node/pull/21520)
* [[`ea9aff44f2`](https://github.com/nodejs/node-gyp/commit/ea9aff44f2)] - **tools**: fix "the the" typos in comments (Masashi Hirano) [nodejs/node#20716](https://github.com/nodejs/node/pull/20716)
* [[`207e5aa4fd`](https://github.com/nodejs/node-gyp/commit/207e5aa4fd)] - **gyp**: implement LD/LDXX for ninja and FIPS (Sam Roberts)
* [[`b416c5f4b7`](https://github.com/nodejs/node-gyp/commit/b416c5f4b7)] - **gyp**: enable cctest to use objects (gyp part) (Daniel Bevenius) [nodejs/node#12450](https://github.com/nodejs/node/pull/12450)
* [[`40692d016b`](https://github.com/nodejs/node-gyp/commit/40692d016b)] - **gyp**: add compile\_commands.json gyp generator (Ben Noordhuis) [nodejs/node#12450](https://github.com/nodejs/node/pull/12450)
* [[`fc3c4e2b10`](https://github.com/nodejs/node-gyp/commit/fc3c4e2b10)] - **gyp**: float gyp patch for long filenames (Anna Henningsen) [nodejs/node#7963](https://github.com/nodejs/node/pull/7963)
* [[`8aedbfdef6`](https://github.com/nodejs/node-gyp/commit/8aedbfdef6)] - **gyp**: backport GYP fix to fix AIX shared suffix (Stewart Addison)
* [[`6cd84b84fc`](https://github.com/nodejs/node-gyp/commit/6cd84b84fc)] - **test**: formatting and minor fixes for execFileSync replacement (Rod Vagg) [#1521](https://github.com/nodejs/node-gyp/pull/1521)
* [[`60e421363f`](https://github.com/nodejs/node-gyp/commit/60e421363f)] - **test**: added test/processExecSync.js for when execFileSync is not available. (Rohit Hazra) [#1492](https://github.com/nodejs/node-gyp/pull/1492)
* [[`969447c5bd`](https://github.com/nodejs/node-gyp/commit/969447c5bd)] - **deps**: bump request to 2.8.7, fixes heok/hawk issues (Rohit Hazra) [#1492](https://github.com/nodejs/node-gyp/pull/1492)
* [[`340403ccfe`](https://github.com/nodejs/node-gyp/commit/340403ccfe)] - **win**: improve parsing of SDK version (Alessandro Vergani) [#1516](https://github.com/nodejs/node-gyp/pull/1516)

v3.7.0 2018-06-08
=================

* [[`84cea7b30d`](https://github.com/nodejs/node-gyp/commit/84cea7b30d)] - Remove unused gyp test scripts. (Ben Noordhuis) [#1458](https://github.com/nodejs/node-gyp/pull/1458)
* [[`0540e4ec63`](https://github.com/nodejs/node-gyp/commit/0540e4ec63)] - **gyp**: escape spaces in filenames in make generator (Jeff Senn) [#1436](https://github.com/nodejs/node-gyp/pull/1436)
* [[`88fc6fa0ec`](https://github.com/nodejs/node-gyp/commit/88fc6fa0ec)] - Drop dependency on minimatch. (Brian Woodward) [#1158](https://github.com/nodejs/node-gyp/pull/1158)
* [[`1e203c5148`](https://github.com/nodejs/node-gyp/commit/1e203c5148)] - Fix include path when pointing to Node.js source (Richard Lau) [#1055](https://github.com/nodejs/node-gyp/pull/1055)
* [[`53d8cb967c`](https://github.com/nodejs/node-gyp/commit/53d8cb967c)] - Prefix build targets with /t: on Windows (Natalie Wolfe) [#1164](https://github.com/nodejs/node-gyp/pull/1164)
* [[`53a5f8ff38`](https://github.com/nodejs/node-gyp/commit/53a5f8ff38)] - **gyp**: add support for .mm files to msvs generator (Julien Racle) [#1167](https://github.com/nodejs/node-gyp/pull/1167)
* [[`dd8561e528`](https://github.com/nodejs/node-gyp/commit/dd8561e528)] - **zos**: don't use universal-new-lines mode (John Barboza) [#1451](https://github.com/nodejs/node-gyp/pull/1451)
* [[`e5a69010ed`](https://github.com/nodejs/node-gyp/commit/e5a69010ed)] - **zos**: add search locations for libnode.x (John Barboza) [#1451](https://github.com/nodejs/node-gyp/pull/1451)
* [[`79febace53`](https://github.com/nodejs/node-gyp/commit/79febace53)] - **doc**: update macOS information in README (Josh Parnham) [#1323](https://github.com/nodejs/node-gyp/pull/1323)
* [[`9425448945`](https://github.com/nodejs/node-gyp/commit/9425448945)] - **gyp**: don't print xcodebuild not found errors (Gibson Fahnestock) [#1370](https://github.com/nodejs/node-gyp/pull/1370)
* [[`6f1286f5b2`](https://github.com/nodejs/node-gyp/commit/6f1286f5b2)] - Fix infinite install loop. (Ben Noordhuis) [#1384](https://github.com/nodejs/node-gyp/pull/1384)
* [[`2580b9139e`](https://github.com/nodejs/node-gyp/commit/2580b9139e)] - Update `--nodedir` description in README. (Ben Noordhuis) [#1372](https://github.com/nodejs/node-gyp/pull/1372)
* [[`a61360391a`](https://github.com/nodejs/node-gyp/commit/a61360391a)] - Update README with another way to install on windows (JeffAtDeere) [#1352](https://github.com/nodejs/node-gyp/pull/1352)
* [[`47496bf6dc`](https://github.com/nodejs/node-gyp/commit/47496bf6dc)] - Fix IndexError when parsing GYP files. (Ben Noordhuis) [#1267](https://github.com/nodejs/node-gyp/pull/1267)
* [[`b2024dee7b`](https://github.com/nodejs/node-gyp/commit/b2024dee7b)] - **zos**: support platform (John Barboza) [#1276](https://github.com/nodejs/node-gyp/pull/1276)
* [[`90d86512f4`](https://github.com/nodejs/node-gyp/commit/90d86512f4)] - **win**: run PS with `-NoProfile` (Refael Ackermann) [#1292](https://github.com/nodejs/node-gyp/pull/1292)
* [[`2da5f86ef7`](https://github.com/nodejs/node-gyp/commit/2da5f86ef7)] - **doc**: add github PR and Issue templates (Gibson Fahnestock) [#1228](https://github.com/nodejs/node-gyp/pull/1228)
* [[`a46a770d68`](https://github.com/nodejs/node-gyp/commit/a46a770d68)] - **doc**: update proposed DCO and CoC (Mikeal Rogers) [#1229](https://github.com/nodejs/node-gyp/pull/1229)
* [[`7e803d58e0`](https://github.com/nodejs/node-gyp/commit/7e803d58e0)] - **doc**: headerify the Install instructions (Nick Schonning) [#1225](https://github.com/nodejs/node-gyp/pull/1225)
* [[`f27599193a`](https://github.com/nodejs/node-gyp/commit/f27599193a)] - **gyp**: update xml string encoding conversion (Liu Chao) [#1203](https://github.com/nodejs/node-gyp/pull/1203)
* [[`0a07e481f7`](https://github.com/nodejs/node-gyp/commit/0a07e481f7)] - **configure**: don't set ensure if tarball is set (Gibson Fahnestock) [#1220](https://github.com/nodejs/node-gyp/pull/1220)

v3.6.3 2018-06-08
=================

* [[`90cd2e8da9`](https://github.com/nodejs/node-gyp/commit/90cd2e8da9)] - **gyp**: fix regex to match multi-digit versions (Jonas Hermsmeier) [#1455](https://github.com/nodejs/node-gyp/pull/1455)
* [[`7900122337`](https://github.com/nodejs/node-gyp/commit/7900122337)] - deps: pin `request` version range (Refael Ackerman) [#1300](https://github.com/nodejs/node-gyp/pull/1300)

v3.6.2 2017-06-01
=================

Expand Down
34 changes: 34 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Contributing to node-gyp

## Code of Conduct

Please read the
[Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md)
which explains the minimum behavior expectations for node-gyp contributors.

<a id="developers-certificate-of-origin"></a>
## Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

* (a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

* (b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

* (c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

* (d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Loading