Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: make VS path match case-insensitive #1806

Closed
wants to merge 1 commit into from
Closed

win: make VS path match case-insensitive #1806

wants to merge 1 commit into from

Conversation

joaocgreis
Copy link
Member

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Path comparison should be case-insensitive on Windows. As reported in #1805, VCINSTALLDIR can have the drive letter in lowercase while the information about the installation has it in uppercase.

Fixes: #1805

@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/136/

@joaocgreis joaocgreis mentioned this pull request Jul 4, 2019
Closed
rvagg
rvagg approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path.relative(), neat trick

joaocgreis added a commit that referenced this pull request Jul 8, 2019
@joaocgreis
win: make VS path match case-insensitive
656117c 
Fixes: #1805
PR-URL: #1806
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@joaocgreis
Copy link
Member Author

Landed in 656117c

@joaocgreis joaocgreis closed this Jul 8, 2019
@rvagg rvagg mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@richardlau richardlau richardlau approved these changes

@bzoz bzoz bzoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual Studio finder is doing a case-sensitive path check
4 participants
@joaocgreis @rvagg @richardlau @bzoz