test: cover supported node versions with travis #1809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure. We can work this. A lot of this was done on https://github.com/refack/GYP |
cclauss
reviewed
Jul 5, 2019
| before_install: nvm install 10 | ||
| - name: "Node.js 12 & Python 3.7 on Linux" | ||
| python: 3.7 | ||
| before_install: nvm install 12 | ||
| allow_failures: | ||
| - os: windows |
There was a problem hiding this comment.
Perhaps add python: 3.7 to allow_failures ;-)
|
While you are in here, can you please change F72 on line 39 to F7 so that we add the flake8 F70x tests to our scans? I know that we currently do not have any F70x issues but putting this in place would catch any new occurrences. |
gibberish! but done |
|
Do you understand why Node 6 fails? Is it worth fixing? |
|
yes, it will magically turn green when #1808 is merged |
cclauss
approved these changes
Jul 5, 2019
richardlau
approved these changes
Jul 5, 2019
rvagg
force-pushed
the
rvagg/travis-moar-nodes
branch
from
f844879
to
7bcb6a4
Compare
rvagg
added a commit
that referenced
this pull request
Jul 6, 2019
PR-URL: #1809 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: cclauss <cclauss@me.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might be the best way to get full coverage in travis. @cclauss @joaocgreis