Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: make cmake python3 compatible #1944

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Fix #1943

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

gyp/pylib/gyp/generator/cmake.py Outdated Show resolved Hide resolved
@gengjiawen gengjiawen force-pushed the cmake_py3 branch 2 times, most recently from 31a4540 to 12fe565 Compare October 27, 2019 16:39
@gengjiawen gengjiawen changed the title make cmake python3 compatible gyp: make cmake python3 compatible Oct 29, 2019
rvagg pushed a commit that referenced this pull request Oct 30, 2019
PR-URL: #1944
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member

rvagg commented Oct 30, 2019

landed in d8e09a1

@rvagg rvagg closed this Oct 30, 2019
@cclauss cclauss added the Python label Nov 7, 2019
rvagg pushed a commit that referenced this pull request Nov 18, 2019
PR-URL: #1944
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-gyp configure fails
4 participants